Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solana spl-token-2022 #15902

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Solana spl-token-2022 #15902

merged 1 commit into from
Dec 16, 2024

Conversation

tomasklim
Copy link
Member

@tomasklim tomasklim commented Dec 11, 2024

original #15769

QA manual:

  1. Open desktop solana app
  2. Use backpack to buy some Token2022 type token on Jupiter (try something else then pyusd)
    Screenshot 2024-12-11 at 13 39 55
  3. Check the account on Suite if it now shows the token you bought
  4. Try to send it (suite)
  5. Try to swap it (suite)
  6. Restart and check token is still there

  1. Test it also in web app
  2. ...

Resolve #13538

@tomasklim tomasklim added build-desktop This will trigger the build of desktop apps for your PR solana QA Quality assurance related labels Dec 11, 2024
Copy link

socket-security bot commented Dec 11, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@solana-program/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

github-actions bot commented Dec 11, 2024

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 20
  • More info

Learn more about 𝝠 Expo Github Action

@tomasklim tomasklim force-pushed the solana-token-2022-support branch from ba2796f to 486aed8 Compare December 11, 2024 21:36
@tomasklim tomasklim requested a review from Nodonisko as a code owner December 11, 2024 21:36
@tomasklim
Copy link
Member Author

@SocketSecurity ignore npm/@solana-program/[email protected]

@tomasklim tomasklim force-pushed the solana-token-2022-support branch from 486aed8 to 7d4a13b Compare December 14, 2024 09:08
@tomasklim tomasklim changed the title Test token 22 Solana spl-token-2022 Dec 14, 2024
@tomasklim
Copy link
Member Author

/rebase

Copy link

@trezor-ci trezor-ci force-pushed the solana-token-2022-support branch from 7d4a13b to 2031b7e Compare December 16, 2024 10:12
Copy link
Member

@martykan martykan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my tests, LGTM

@tomasklim tomasklim merged commit 9abc7d9 into develop Dec 16, 2024
72 checks passed
@tomasklim tomasklim deleted the solana-token-2022-support branch December 16, 2024 10:56
@STew790
Copy link
Contributor

STew790 commented Jan 14, 2025

QA OK
I can see tx history of token and I am able to send it.
image
image
image

Info
25.1.2 ac8cd6e

@STew790 STew790 added the QA OK Issue passed QA without any blocker label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-desktop This will trigger the build of desktop apps for your PR QA OK Issue passed QA without any blocker QA Quality assurance related solana
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

Solana Token2022
4 participants