chore: refactoring of the TxDetailModal to split the BumpFee (rbf) flow #15977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-sanderson
commented
Dec 16, 2024
...rc/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/ChangeFee/ChangeFee.tsx
Show resolved
Hide resolved
...ponents/suite/modals/ReduxModal/UserContextModal/TxDetailModal/ChangeFee/ReplaceTxButton.tsx
Show resolved
Hide resolved
...rc/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/ChangeFee/ChangeFee.tsx
Show resolved
Hide resolved
...uite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/TxDetailModal.tsx
Show resolved
Hide resolved
peter-sanderson
commented
Dec 16, 2024
...uite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/TxDetailModal.tsx
Show resolved
Hide resolved
peter-sanderson
commented
Dec 16, 2024
.../src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/TxDetailModalBase.tsx
Show resolved
Hide resolved
Lemonexe
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Amazing 🚀
I am delighted to witness such maximum despaghettification. The bottom content, heading, buttons callbacks, all that used to be such an iffy labyrinth of ifs and now it's neatly organised by concern 🙌 ❤️
Tested briefly with regtest, seems to be working fine, the bug with RBF fixed ✔️
EDIT: now I see that TS is broken in useRbfForm.test.tsx. That might be harder to update, as you'll need to render the context to test the <ReplaceTxButton />, or it might be ez, idk..
...ponents/suite/modals/ReduxModal/UserContextModal/TxDetailModal/ChangeFee/ReplaceTxButton.tsx
Outdated
Show resolved
Hide resolved
Lemonexe
reviewed
Dec 16, 2024
peter-sanderson
force-pushed
the
bump-custom-fee
branch
3 times, most recently
from
c97c0ef to
6f3d9fe
Compare
Lemonexe
approved these changes
Dec 17, 2024
...uite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/TxDetailModal.tsx
Outdated
Show resolved
Hide resolved
adamhavel
approved these changes
Dec 17, 2024
peter-sanderson
force-pushed
the
bump-custom-fee
branch
from
6f3d9fe to
1c5a5a9
Compare
Lemonexe
approved these changes
Dec 18, 2024
|
🚀 Expo preview is ready!
|
peter-sanderson
force-pushed
the
bump-custom-fee
branch
from
1c5a5a9 to
0e622f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I am separating the code for
TxDetailModalandTxDetailModalwith bump-fee (RBF) form in it. The issue here is, thatuseRbfis used twice, so the internal form state is initialized twice. User changes fee in one, but when they submit it, the different state is used (with just default values). This result in the bug, there the custom fee is not used when set.👉 For code-review, it will be best go commit by commit.
Resolves: #15598