Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add TREZOR_PRE_COMMIT_ESLINT_SKIP global flax to skip pre-commit hook for ESLint #16006

Merged
merged 1 commit into from
Dec 17, 2024
Merged

chore: add TREZOR_PRE_COMMIT_ESLINT_SKIP global flax to skip pre-commit hook for ESLint #16006

merged 1 commit into from
Dec 17, 2024

Conversation

peter-sanderson
Copy link
Contributor

@peter-sanderson peter-sanderson commented Dec 17, 2024 •
edited
Loading

Useful if you do lint on file-save in IDE.

To make it persistent you need to add:

export TREZOR_PRE_COMMIT_ESLINT_SKIP=false

Into you .bashrc (or `.zshrc, or similar...) file.

image
image

@enjojoy
Copy link
Contributor

enjojoy commented Dec 17, 2024

Nice, thank you 👍🏻

enjojoy
enjojoy approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@enjojoy enjojoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 Useful for those already running linting in their IDE

@peter-sanderson peter-sanderson merged commit e0fd625 into develop Dec 17, 2024
28 checks passed
@peter-sanderson peter-sanderson deleted the flag-to-disable-eslint-hook branch December 17, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enjojoy enjojoy enjojoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues Suite
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter-sanderson @enjojoy