Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(suite-native): use correct alert colors for the dark theme #16090

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix(suite-native): use correct alert colors for the dark theme #16090

merged 1 commit into from
Jan 7, 2025

Conversation

yanascz
Copy link
Contributor

@yanascz yanascz commented Dec 20, 2024 •
edited
Loading

  • Used correct alert colors for the dark theme
  • Removed unused alert colors for elevation 3

Fixes based on Figma provided by @shenkys.

Screenshots:

Simulator Screenshot - iPhone 16 Pro - 2024-12-20 at 16 39 52

Affected components in desktop version:
image

@yanascz yanascz added the mobile Suite Lite issues and PRs label Dec 20, 2024
@jvaclavik
Copy link
Contributor

LGTM

@jvaclavik
Copy link
Contributor

FYI small color update of IconCircle component (desktop), but it looks better:

before
Screenshot 2025-01-07 at 09 56 29_before

after
Screenshot 2025-01-07 at 09 55 43_after

@yanascz yanascz merged commit 98b2554 into develop Jan 7, 2025
29 of 30 checks passed
@yanascz yanascz deleted the fix/native/dark-theme-alert-colors branch January 7, 2025 09:02
@STew790
Copy link
Contributor

STew790 commented Jan 15, 2025

QA OK
LGTM
image
image
image

Info
25.1.2 995410a

@STew790 STew790 added the QA OK Issue passed QA without any blocker label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvaclavik jvaclavik jvaclavik approved these changes

@Nodonisko Nodonisko Awaiting requested review from Nodonisko Nodonisko is a code owner

@adamhavel adamhavel Awaiting requested review from adamhavel adamhavel is a code owner

Assignees

@yanascz yanascz

Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Projects
Suite Mobile
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanascz @jvaclavik @STew790