feat(mobile): update FW alert on Home + remote feature flag #16318
Conversation
|
🚀 Expo preview is ready!
|
Nodonisko
force-pushed
the
feat/update-firmware-alert
branch
from
cb30b94 to
215e8f9
Compare
Nodonisko
requested review from
a team,
tomasklim and
matejkriz
as code owners
Nodonisko
force-pushed
the
feat/update-firmware-alert
branch
from
215e8f9 to
b512d83
Compare
Nodonisko
changed the title
suite-native/atoms/src/Stack.tsx
Outdated
| const AnimatedStack = Animated.createAnimatedComponent(Stack); | ||
| AnimatedStack.displayName = 'AnimatedStack'; | ||
| export const AnimatedVStack = AnimatedStack; | ||
| export const AnimatedHStack = AnimatedStack; |
There was a problem hiding this comment.
Is orientation missing here intentionally? 🤔
There was a problem hiding this comment.
Good catch, fixed
Nodonisko
force-pushed
the
feat/update-firmware-alert
branch
from
b512d83 to
5305247
Compare
Nodonisko
force-pushed
the
feat/update-firmware-alert
branch
from
5305247 to
6472290
Compare
| @@ -25,6 +25,7 @@ export const Feature = { | |||
| ethClaim: 'eth.staking.claim', | |||
| firmwareRevisionCheck: 'security.firmware.check', | |||
| firmwareHashCheck: 'security.firmware.hashCheck', | |||
| firmwareUpdate: 'device.firmware.update', | |||
There was a problem hiding this comment.
I'm thinking whether we should indicate somehow, that this feature flag is implemented on mobile only. My initial thought was using mobile prefix in the id, but since those features can be implemented later on the other platform, I'm not proposing that. We can use comments if needed. Feel free to keep it as it is.
| selectIsFeatureEnabled(state, Feature.firmwareUpdate, true), | ||
| ); | ||
|
|
||
| const isFirmwareUpdateEnabled = localFeatureFlag && remoteFeatureFlag; |
There was a problem hiding this comment.
This way it wouldn't be available on production for users at all, because localFeatureFlag has default value isDevelopOrDebugEnv(). And there is no way to enable it locally if it's remotely disabled. I guess OR makes more sense here.
| const isFirmwareUpdateEnabled = localFeatureFlag && remoteFeatureFlag; | |
| const isFirmwareUpdateEnabled = localFeatureFlag || remoteFeatureFlag; |
Description
Related Issue
Resolve part of #15584
Screenshots:
screen-20250113-145307.mp4