New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/connect entropy check error code #16345

Merged

komret merged 2 commits into develop from fix/connect-entropy-check-error-code

Jan 14, 2025

Contributor

komret commented Jan 14, 2025

Return Failure_EntropyCheck instead of Failure_InvalidSession on devices not supporting entropy check.
Display error toast only on Failure_EntropyCheck error.

szymonlesisz and others added 2 commits

January 13, 2025 16:10


          fix(connect): resetDevice typed error

f6468c7


          fix(suite): show toast only on entropy check fail

39a142f

komret added the release label

komret requested review from mroz22, szymonlesisz, martykan and marekrjpolak as code owners

January 14, 2025 10:51

szymonlesisz approved these changes

View reviewed changes

komret merged commit d186751 into develop

75 of 76 checks passed

komret deleted the fix/connect-entropy-check-error-code branch

January 14, 2025 11:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

szymonlesisz szymonlesisz approved these changes

mroz22 Awaiting requested review from mroz22 mroz22 is a code owner

martykan Awaiting requested review from martykan martykan is a code owner

marekrjpolak Awaiting requested review from marekrjpolak marekrjpolak is a code owner

Labels

release