chore(suite-native): make it simple to use Sentry locally in debug build #16356
Conversation
matejkriz
added
sentry
| @@ -94,4 +93,4 @@ const PureApp = () => ( | |||
| </GestureHandlerRootView> | |||
| ); | |||
|
|
|||
| export const App = isDebugEnv() ? PureApp : Sentry.wrap(PureApp); | |||
| export const App = Sentry.wrap(PureApp); | |||
There was a problem hiding this comment.
I know that we added that condition because of some warning during local development, but now I can't see that warning any more and I guess it is because I removed the condition for Sentry.init and just playing with the enabled property.
suite-native/app/.env.development
Outdated
| @@ -1,2 +1,3 @@ | |||
| EXPO_PUBLIC_ENVIRONMENT=debug | |||
| EXPO_PUBLIC_IS_ANALYTICS_LOGGER_ENABLED=false | |||
| EXPO_PUBLIC_IS_SENTRY_ENABLED=false | |||
There was a problem hiding this comment.
I would like to have it on for development build it helps catch lot of stuff that happens during QA etc. It was like that since beginning.
There was a problem hiding this comment.
I see it is confusing, but it still works like that, because the condition for enabling is enabled: !isDebugEnv() || process.env.EXPO_PUBLIC_IS_SENTRY_ENABLED === 'true',. I'll add comment here.
There was a problem hiding this comment.
I'm changing the name to EXPO_PUBLIC_IS_SENTRY_ON_DEBUG_BUILD_ENABLED instead of the comment to make it more clear.
|
🚀 Expo preview is ready!
|
Description
Turning on Sentry in the local debug build is now complicated and one has to rewrite several places. This PR tries to simplify it.
From now on it should be enough to switch
EXPO_PUBLIC_IS_SENTRY_ENABLEDin.env.development.localand do a prebuild.