Merge pull request #13033 from brian-kelley/DisableCublasDot

KokkosKernels: disable cuBLAS dot wrapper
trilinos · May 22, 2024 · 0eaab92 · 0eaab92
2 parents 491cb5b + c0bf05a
commit 0eaab92
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/packages/kokkos-kernels/blas/tpls/KokkosBlas1_dot_tpl_spec_avail.hpp b/packages/kokkos-kernels/blas/tpls/KokkosBlas1_dot_tpl_spec_avail.hpp
@@ -89,9 +89,15 @@ KOKKOSBLAS1_DOT_TPL_SPEC_AVAIL_BLAS(Kokkos::complex<float>, Kokkos::LayoutLeft,
   KOKKOSBLAS1_DOT_TPL_SPEC(Kokkos::complex<double>, LAYOUT, EXECSPACE, MEMSPACE)
 
 #ifdef KOKKOSKERNELS_ENABLE_TPL_CUBLAS
+// Note BMK: CUBLAS dot is consistently slower than our native dot
+// (measured 11.2, 11.8, 12.0 using perf test, and all are similar)
+// If a future version improves performance, re-enable it here and
+// in the tpl_spec_decl file.
+#if 0
 KOKKOSBLAS1_DOT_TPL_SPEC_AVAIL(Kokkos::LayoutLeft, Kokkos::Cuda,
                                Kokkos::CudaSpace)
 #endif
+#endif
 
 #ifdef KOKKOSKERNELS_ENABLE_TPL_ROCBLAS
 KOKKOSBLAS1_DOT_TPL_SPEC_AVAIL(Kokkos::LayoutLeft, Kokkos::HIP,

diff --git a/packages/kokkos-kernels/blas/tpls/KokkosBlas1_dot_tpl_spec_decl.hpp b/packages/kokkos-kernels/blas/tpls/KokkosBlas1_dot_tpl_spec_decl.hpp
@@ -101,6 +101,9 @@ KOKKOSBLAS1_DOT_TPL_SPEC_DECL_BLAS_EXT(false)
 
 // cuBLAS
 #ifdef KOKKOSKERNELS_ENABLE_TPL_CUBLAS
+// Disabled because native has better performance.
+// See tpl_spec_avail file for more details
+#if 0
 #include <KokkosBlas_tpl_spec.hpp>
 
 namespace KokkosBlas {
@@ -174,6 +177,7 @@ KOKKOSBLAS1_DOT_TPL_SPEC_DECL_CUBLAS_EXT(false)
 }  // namespace Impl
 }  // namespace KokkosBlas
 #endif
+#endif
 
 // rocBLAS
 #ifdef KOKKOSKERNELS_ENABLE_TPL_ROCBLAS