Skip to content

Commit

Permalink
tpetra: update supported kokkos version to 4.5.1
Browse files Browse the repository at this point in the history 
Signed-off-by: Nathan Ellingwood <[email protected]>
  • Loading branch information
@ndellingwood
ndellingwood committed Dec 19, 2024
1 parent a748c40 commit d78b31d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/tpetra/CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ TRIBITS_ADD_OPTION_AND_DEFINE(
# Supported Kokkos version in Trilinos
# NOTE: When we snapshot Kokkos into Trilinos, we have to update these numbers to maintain
# compatibility with external Kokkos
SET(Tpetra_SUPPORTED_KOKKOS_VERSION "4.5.0")
SET(Tpetra_SUPPORTED_KOKKOS_VERSION "4.5.1")


# Option to allow developers to ignore incompatible Kokkos versions
Expand Down

2 comments on commit d78b31d

@aperijake
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndellingwood I am trying to build trilinos@master with spack, and this is causing me problems. Looking at kokkos, I think the latest release is 4.5.00, and there is a release candidate branch for 4.5.01. Is having 4.5.1 here correct, or is it a typo?

@ndellingwood
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aperijake this change was included with the kokkos 4.5.1 patch release snapshot to Trilinos in ##13679 , 4.5.1 is correct. See for example here for the corresponding marking in kokkos as part of that PR

Please sign in to comment.