ifpack2: Remove Kokkos::subview calls from ComputeResidualVector kernel. #12437

vbrunini · 2023-10-24T17:53:47Z

This fixes a large performance regression seen in SPARC after the kokkos-3.6.01 promotion, see issue kokkos/kokkos#6533.
@srajama1 @kliegeois

trilinos-autotester · 2023-10-25T00:32:05Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

trilinos-autotester · 2023-10-25T01:16:26Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

trilinos-autotester · 2023-10-25T01:16:33Z

Status Flag 'Pull Request AutoTester' - GitHub reports Mergeable status = False

kliegeois

This looks good to me, thanks!
However, you will need to rebase the PR branch on Trilinos/develop.

trilinos-autotester · 2023-10-25T03:23:27Z

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

trilinos-autotester · 2023-10-25T03:23:30Z

Status Flag 'Pull Request AutoTester' - GitHub reports Mergeable status = False

This fixes a large performance regression seen in SPARC after the kokkos-3.6.01 promotion, see issue kokkos/kokkos#6533.

trilinos-autotester · 2023-10-25T16:39:23Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

jhux2

lgtm

trilinos-autotester · 2023-10-25T17:11:17Z

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

trilinos-autotester · 2023-10-25T17:11:23Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

trilinos-autotester · 2023-10-25T17:13:08Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 3162
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1661
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1651
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1650
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2858
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2653
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 1292
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Using Repos:

Repo: TRILINOS (vbrunini/Trilinos)

Pull Request Author: vbrunini

trilinos-autotester · 2023-10-25T20:17:20Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 3162
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1661
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1651
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1650
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2858
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2653
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 1292
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

CDash Test Results for PR# 12437.

Wiki: How to Reproduce PR Testing Builds and Errors.

trilinos-autotester · 2023-10-26T06:40:39Z

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

trilinos-autotester · 2023-10-26T06:43:42Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 3170
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1669
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1659
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1658
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2866
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2661
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 1300
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Using Repos:

Repo: TRILINOS (vbrunini/Trilinos)

Pull Request Author: vbrunini

trilinos-autotester · 2023-10-26T09:27:14Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 3170
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1669
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1659
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1658
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2866
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2661
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 1300
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS	pkg: Ifpack2;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM	12437
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`bd2f483`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ff154a`

CDash Test Results for PR# 12437.

trilinos-autotester · 2023-10-26T09:27:33Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jhux2 ]!

trilinos-autotester · 2023-10-26T09:27:40Z

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

trilinos-autotester · 2023-10-26T09:27:53Z

Merge on Pull Request# 12437: IS A SUCCESS - Pull Request successfully merged

crtrott · 2023-10-31T15:08:13Z

packages/ifpack2/src/Ifpack2_BlockComputeResidualVector.hpp

-        auto xx_remote = Kokkos::subview(x_remote, block_range, 0);
-        auto yy = Kokkos::subview(y_packed_scalar, 0, block_range, 0, 0);
+        using subview_1D_right_t = decltype(Kokkos::subview(b, block_range, 0));
+        subview_1D_right_t bb(nullptr, blocksize);


This is sooo very illegal

crtrott · 2023-10-31T15:09:43Z

This is pretty illegal and a clear violation of preconditions. No guarantee that this will not break in a future Kokkos version in debug mode.

crtrott · 2023-10-31T15:10:10Z

Can someone at least check whether the actual proposed thing in the Kokkos issue would fix the issue too?

vbrunini requested a review from a team as a code owner October 24, 2023 17:53

jhux2 added pkg: Ifpack2 AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. labels Oct 25, 2023

trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Oct 25, 2023

kliegeois added the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Oct 25, 2023

kliegeois reviewed Oct 25, 2023

View reviewed changes

trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Oct 25, 2023

ifpack2: Remove Kokkos::subview calls from ComputeResidualVector kernel.

bd2f483

This fixes a large performance regression seen in SPARC after the kokkos-3.6.01 promotion, see issue kokkos/kokkos#6533.

vbrunini force-pushed the vebruni/ifpack2_block_tridi_perf branch from a877537 to bd2f483 Compare October 25, 2023 15:07

jhux2 approved these changes Oct 25, 2023

View reviewed changes

trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Oct 25, 2023

trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Oct 25, 2023

jhux2 added the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Oct 25, 2023

jhux2 mentioned this pull request Oct 25, 2023

Random test timeouts bringing down PR build & test iterations 2023 #12391

Open

trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Oct 26, 2023

trilinos-autotester merged commit 243aaa5 into trilinos:develop Oct 26, 2023
2 checks passed

trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Oct 26, 2023

kliegeois added a commit that referenced this pull request Oct 26, 2023

Include modification of #12437

0748acb

crtrott reviewed Oct 31, 2023

View reviewed changes

ifpack2: Remove Kokkos::subview calls from ComputeResidualVector kernel. #12437

ifpack2: Remove Kokkos::subview calls from ComputeResidualVector kernel. #12437

Conversation

vbrunini commented Oct 24, 2023

trilinos-autotester commented Oct 25, 2023

trilinos-autotester commented Oct 25, 2023

trilinos-autotester commented Oct 25, 2023

kliegeois left a comment

Choose a reason for hiding this comment

trilinos-autotester commented Oct 25, 2023

trilinos-autotester commented Oct 25, 2023

trilinos-autotester commented Oct 25, 2023

jhux2 left a comment

Choose a reason for hiding this comment

trilinos-autotester commented Oct 25, 2023

trilinos-autotester commented Oct 25, 2023

trilinos-autotester commented Oct 25, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-2021.3

Jenkins Parameters

Using Repos:

trilinos-autotester commented Oct 25, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-2021.3

Jenkins Parameters

trilinos-autotester commented Oct 26, 2023

trilinos-autotester commented Oct 26, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off