fix(Intrepid2): implicit by-copy capture of this is deprecated warnings #13698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
mperego
added
the
AT: PRE-TEST INSPECTED
trilinos-autotester
removed
the
AT: PRE-TEST INSPECTED
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: maartenarnst |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
5 similar comments
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
mperego
approved these changes
Jan 2, 2025
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ mperego ]! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
maartenarnst
force-pushed
the
intrepid2-implicit-this
branch
from
e8e279c to
85b9c43
Compare
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
Hi @mperego. I have just rebased, signed and pushed again. Hopefully it will work now :) |
|
Hi @maartenarnst, the commit message should contain https://github.com/trilinos/Trilinos/pull/13698/checks?check_run_id=35079608734 |
Signed-off-by: Maarten Arnst <[email protected]>
maartenarnst
force-pushed
the
intrepid2-implicit-this
branch
from
85b9c43 to
db59fc9
Compare
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
mperego
added
AT: PRE-TEST INSPECTED
trilinos-autotester
removed
the
AT: PRE-TEST INSPECTED
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: maartenarnst |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ mperego ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13698: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13698: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13698: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13698: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13698: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13698: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13698: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13698: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13698: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13698: Github Mergeability = blocked; Git Mergeable = True |
|
@trilinos/framework Is this an issue with AT2 or do we need to add @maartenarnst to some group? |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13698: Github Mergeability = blocked; Git Mergeable = True |
He will need to have somebody from Sandia re-run the workflow. I believe the 'Developers' part of that message is inaccurate. I just clicked re-run and it is running now. |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13698: Github Mergeability = blocked; Git Mergeable = True |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mperego @CamelliaDPG
This PR fixes "implicit by-copy capture of this is deprecated" warnings when compiling
Intrepid2after:The PR #13437 uses lambdas that capture class variables, but the implicit capture of
thisis deprecated. When we compile withnvccwithcuda12.6 andgcc13.3 as the host compiler and C++20 standard, we get compilation errors.This PR is a proposed solution with "capture with initializer".