NAS-133437 / 25.04 / Better handle docker not starting on boot when on HDDs #15376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
sonicaj
force-pushed
the
NAS-133437
branch
5 times, most recently
from
bb77806 to
e542e02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes to better handle docker state when HDDs are being used for apps. Basically what was happening was that when HDDs based pool is being used for starting apps, it can take a few minutes to get apps to start - while we were waiting for 2 minutes earlier and then setting our status to failure. Now systemd would after a few minutes have docker start just fine but middleware would report it as being in failed state.
The changes being done here have made sure that middleware reflects systemd status and systemd fails docker service after 15 minutes of waiting for it to start (earlier docker had removed the systemd time limit which meant systemd would not have been marking it as failed to start and would wait).