Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131747 / 25.04 / "Update available" tooltip for Apps shows wrong version #10966

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing:
See ticket.

Middleware updated us with latest_version field, so we used it.

@AlexKarpov98 AlexKarpov98 self-assigned this Nov 4, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner November 4, 2024 10:52
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team November 4, 2024 10:52
@bugclerk bugclerk changed the title NAS-131747: "Update available" tooltip for Apps shows wrong version NAS-131747 / 25.04 / "Update available" tooltip for Apps shows wrong version Nov 4, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Nov 4, 2024

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.94%. Comparing base (9332635) to head (d5ac62c).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10966   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files        1607     1609    +2     
  Lines       56681    56677    -4     
  Branches     5869     5867    -2     
=======================================
- Hits        46445    46443    -2     
+ Misses      10236    10234    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the version is there.

@AlexKarpov98 AlexKarpov98 merged commit 4099ac7 into master Nov 4, 2024
11 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-131747 branch November 4, 2024 13:53
@bugclerk
Copy link
Contributor

bugclerk commented Nov 4, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants