NAS-132705 / 25.04 / Adopts middleware changes to CPU and memory reporting on the dashboard widgets #11317
+48
−280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
undsoft
requested changes
Jan 9, 2025
There was a problem hiding this comment.
There is a number of issues most of them are not because of changes in this PR, but let's still fix them.
- I get
toSignalerror. Can be fixed by adding.pipe(startWith(0))torefreshInterval$inWidgetResourcesService. - I've tried simulating load on CPU to test the widget and noticed that load is reported as System on main chart, but bars don't show much. Looks like an issue with MW reporting. I think users would expect to see total load on bars as well.
3. Memory overview widget doesn't load.
4. Let's remove CPU Usage Per Core from default set of widgets as currently there is a gap there.
RehanY147
changed the title
undsoft
approved these changes
Jan 13, 2025
| @@ -80,6 +80,7 @@ | |||
| "@lezer/common": "~1.2.1", | |||
| "@lezer/generator": "~1.7.1", | |||
| "@lezer/lr": "~1.4.2", | |||
| "@marijn/find-cluster-break": "~1.0.2", | |||
There was a problem hiding this comment.
I don't know why this package is needed. It's not used anywhere and it works for me without it. Sounds like an issue on your end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Adopts middleware changes to CPU reporting on the dashboard widgets. Removes temperature related reporting also temperature for cpu widget
Testing:
With a recent build, CPU stats related widgets should work correctly. Also shouldn't show any errors in the console logs