NAS-132330 / 25.04 / Update TrueNAS Brand #11318
Open
+587
−297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denysbutenko
changed the title
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #11318 +/- ##
==========================================
+ Coverage 82.75% 82.76% +0.01%
==========================================
Files 1654 1655 +1
Lines 59133 59179 +46
Branches 6210 6224 +14
==========================================
+ Hits 48936 48981 +45
- Misses 10197 10198 +1 ☔ View full report in Codecov by Sentry. |
undsoft
requested changes
Jan 13, 2025
| @@ -17,7 +17,7 @@ target="_blank">Enterprise level</a> support and services? Contact \ | |||
| <a href="https://www.ixsystems.com/quote-form/?utm_source=truenas+core+ui&utm_medium=os&utm_campaign=welcome"\ | |||
| target="_blank">iXsystems</a> for more information.'), | |||
|
|
|||
| opensource: T('TrueNAS is Free and <a href="https://github.com/truenas/" target="_blank"> \ | |||
| opensource: T('TrueNAS Community Edition is Free and <a href="https://github.com/truenas/" target="_blank"> \ | |||
There was a problem hiding this comment.
The text still applies to an Enterprise editing as well. (Free as in freedom).
You can probably keep showing old text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
TrueNAS Community Editionfor SCALETrueNAS Enterprisefor SCALE EnterpriseTesting:
Check affected places for regressions on desktop and mobile.
Downstream