Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133481 / 25.04 / Changes for VMs in new virtualization #11323

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

denysbutenko
Copy link
Member

@denysbutenko denysbutenko commented Jan 10, 2025

Changes:

  1. Makes CPU and Memory attributes required again.
  2. Update Disks picker, remove destionation and allows to pick zvols only.
  3. Updated ix-explorer allows to list zvols only.

Testing:

Checks Instance Wizard on Virtualization page.

Downstream

Affects Reasoning
Documentation Instance Wizard changes

@denysbutenko denysbutenko requested a review from a team as a code owner January 10, 2025 12:37
@denysbutenko denysbutenko requested review from RehanY147 and removed request for a team January 10, 2025 12:37
@bugclerk bugclerk changed the title NAS-133481: Changes for VMs in new virtualization NAS-133481 / 25.04 / Changes for VMs in new virtualization Jan 10, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.74%. Comparing base (5faa6c2) to head (bc1c56c).
Report is 5 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app/services/filesystem.service.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11323      +/-   ##
==========================================
- Coverage   82.75%   82.74%   -0.01%     
==========================================
  Files        1654     1654              
  Lines       59133    59134       +1     
  Branches     6210     6217       +7     
==========================================
- Hits        48936    48933       -3     
- Misses      10197    10201       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants