NAS-133481 / 25.04 / Changes for VMs in new virtualization #11323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #11323 +/- ##
===========================================
- Coverage 82.74% 53.27% -29.47%
===========================================
Files 1654 1654
Lines 59135 59158 +23
Branches 6218 6225 +7
===========================================
- Hits 48932 31518 -17414
- Misses 10203 27640 +17437 ☔ View full report in Codecov by Sentry. |
RehanY147
requested changes
Jan 15, 2025
| @@ -63,6 +63,8 @@ export class InstanceDiskFormComponent implements OnInit { | |||
| return !this.isNew() ? this.translate.instant('Edit Disk') : this.translate.instant('Add Disk'); | |||
| }); | |||
|
|
|||
| protected instance = computed(() => this.slideInRef.getData().instance); | |||
There was a problem hiding this comment.
The computed callback doesn't have a signal call. This could just be a signal.
protected instance = signal(this.slideInRef.getData().instance); Or maybe doesn't need to be a signal
| @@ -112,7 +117,7 @@ export class InstanceDiskFormComponent implements OnInit { | |||
| } | |||
|
|
|||
| private prepareRequest(): Observable<unknown> { | |||
| const instanceId = this.slideInRef.getData().instanceId; | |||
| const instanceId = this.slideInRef.getData().instance.id; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Testing:
Checks Instance Wizard on Virtualization page.
Downstream