Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133442 / 25.04 / hide SED related options in UI #11328

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

denysbutenko
Copy link
Member

Changes:

  • hide SED related options in UI

Testing:

Check ticket and related components.

Downstream

Affects Reasoning
Documentation hide SED related options in UI for Community Edition users who haven't configured SED

@denysbutenko denysbutenko requested a review from a team as a code owner January 13, 2025 12:59
@denysbutenko denysbutenko requested review from RehanY147 and removed request for a team January 13, 2025 12:59
@bugclerk bugclerk changed the title hide SED related options in UI NAS-133442 / 25.04 / hide SED related options in UI Jan 13, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 59.36%. Comparing base (248fd2c) to head (e4fb877).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../disks/components/disk-form/disk-form.component.ts 0.00% 16 Missing ⚠️
...k-encryption/hardware-disk-encryption.component.ts 0.00% 14 Missing ⚠️
...ges/system/advanced/advanced-settings.component.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #11328       +/-   ##
===========================================
- Coverage   82.75%   59.36%   -23.39%     
===========================================
  Files        1654     1654               
  Lines       59132    59140        +8     
  Branches     6217     6219        +2     
===========================================
- Hits        48934    35108    -13826     
- Misses      10198    24032    +13834     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants