Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132826 / 25.04 / Advanced Replication: Got an error when creating a Replication task including snapshots with "Matching naming schema" and "Matching regular expression" #11329

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

AlexKarpov98
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 commented Jan 13, 2025

Testing: see ticket.
Read comments.
Code review may be enough.
Screenshot 2025-01-13 at 15 14 40

…ation task including snapshots with "Matching naming schema" and "Matching regular expression"
@AlexKarpov98 AlexKarpov98 self-assigned this Jan 13, 2025
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner January 13, 2025 13:14
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and removed request for a team January 13, 2025 13:14
@bugclerk bugclerk changed the title NAS-132826: Advanced Replication: Got an error when creating a Replication task including snapshots with "Matching naming schema" and "Matching regular expression" NAS-132826 / 25.04 / Advanced Replication: Got an error when creating a Replication task including snapshots with "Matching naming schema" and "Matching regular expression" Jan 13, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.75%. Comparing base (1db0212) to head (cdfd48b).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ms/components/ix-explorer/ix-explorer.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11329   +/-   ##
=======================================
  Coverage   82.74%   82.75%           
=======================================
  Files        1654     1654           
  Lines       59133    59135    +2     
  Branches     6217     6218    +1     
=======================================
+ Hits        48932    48935    +3     
+ Misses      10201    10200    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 merged commit 0f70118 into master Jan 14, 2025
8 of 9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-132826-ee branch January 14, 2025 10:31
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants