Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133467 / 25.04 / GUI: Extending VDEV progress is blocking #11330

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket.

Code review may be enough.

@AlexKarpov98 AlexKarpov98 self-assigned this Jan 13, 2025
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner January 13, 2025 17:15
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team January 13, 2025 17:15
@bugclerk bugclerk changed the title NAS-133467: GUI: Extending VDEV progress is blocking NAS-133467 / 25.04 / GUI: Extending VDEV progress is blocking Jan 13, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.75%. Comparing base (1db0212) to head (f91e7b6).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11330   +/-   ##
=======================================
  Coverage   82.74%   82.75%           
=======================================
  Files        1654     1654           
  Lines       59133    59133           
  Branches     6217     6217           
=======================================
+ Hits        48932    48935    +3     
+ Misses      10201    10198    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexKarpov98 AlexKarpov98 merged commit 56079f8 into master Jan 14, 2025
9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-133467 branch January 14, 2025 09:22
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants