New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metabase] Update to use hyphen based args #62

Merged

riya-n merged 2 commits into master from riya/fix-underscore

Jan 10, 2024

riya-n commented Jan 10, 2024 •

edited

Loading

as per changes in Change from underscore to hyphen analytics-uploader#10
also we want to upload the results whether the tests pass or fail (hence the if: "!cancelled()")

fix

fc1ee89

riya-n requested review from zaycev, EliSchleifer and mmatheson

January 10, 2024 06:25

riya-n changed the title ~~Update to use hyphen based args~~ [metabase] Update to use hyphen based args

riya-n added the no-backport label

riya-n requested a review from gnalh

January 10, 2024 06:53


          continue on failed test too

0e0f7f5

zaycev approved these changes

View reviewed changes

riya-n merged commit 2260799 into master

100 checks passed

riya-n deleted the riya/fix-underscore branch

January 10, 2024 15:19

github-actions bot commented Jan 10, 2024

@riya-n Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels