Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: minor user experience improvements #82

Merged
merged 8 commits into from
Jan 11, 2024
Merged

refactor: minor user experience improvements #82

merged 8 commits into from
Jan 11, 2024

Conversation

tshakalekholoane
Copy link
Owner

User facing

  • Display helpful message for fatal errors and prompt the user to file a report.
  • Fix an uncaught exception when the user is denied permission while attempting to delete systemd service files.

Development

  • Replace the gotest.tools/assert dependency with a tshaka.dev/x/diff for comparing string test output.
  • Update option parsing to ignore all other arguments when the --help flag is passed.
  • Simplify calls to print to standard output.
  • Reduce clatter by abstracting battery related functionality.

@tshakalekholoane
test: remove gotest.tools/assert dependency
562c103 
The diff functionality required here can be substituted with a lighter
package i.e., tshaka.dev/x/diff.
@tshakalekholoane
refactor: set bat: prefix for fatal errors
4e70f64
@tshakalekholoane
refactor: update option parsing
a690f56
@tshakalekholoane
refactor: simplify calls to print to stdout
c41d0e9
@tshakalekholoane
refactor: abstract battery related functionality
2347dbd
@tshakalekholoane
refactor: add panic recovery
b6a1c91 
Return an actionable message when a fatal error occurs and prompt the
user to file a report using the --debug flag which outputs the error and
stack trace.
@tshakalekholoane
fix: catch insufficient permission error
7d74249 
Return a helpful message after encountering a permission error when
attempting to delete systemd service files.
@tshakalekholoane tshakalekholoane added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Jan 11, 2024
@tshakalekholoane tshakalekholoane self-assigned this Jan 11, 2024
pepa65
pepa65 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@pepa65 pepa65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Cool to catch panics..!

@tshakalekholoane
Copy link
Owner Author

Thank you for the review, @pepa65!

@tshakalekholoane tshakalekholoane merged commit 0f26976 into main Jan 11, 2024
9 checks passed
@tshakalekholoane tshakalekholoane deleted the tshaka/stable branch January 11, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepa65 pepa65 pepa65 approved these changes

Assignees

@tshakalekholoane tshakalekholoane

Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tshakalekholoane @pepa65