Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GHC 9.8 to update-ghc workflow #1999

Merged
merged 7 commits into from
Nov 6, 2023
Merged

Add GHC 9.8 to update-ghc workflow #1999

merged 7 commits into from
Nov 6, 2023

Conversation

avdv
Copy link
Member

@avdv avdv commented Oct 26, 2023

GHC 9.8.1 has been released a few weeks ago. This PR enables updates to the generated bindist file for this stable release too.

  • Simplify and refactor the gen_ghc_bindist.py script to keep the GHC versions we generate entries for in the same place.
    These are now just stored in ghc_bindist_generated.json file.
  • Add 9.8 to the ghc matrix variable to keep it updated

avdv added 7 commits October 26, 2023 09:25
@avdv
CI: Always run update-ghc workflow on current master
4fb3d3e
@avdv
Simplify gen_ghc_bindist.py script
a5b9d2e 
Remove the `ignore_prefixes` and `ignore_suffixes` handling.

We only process .tar.xz files from the `SHA256SUMS` file expecting a specific prefix.
@avdv
Keep a simple list of GHC versions in the gen_ghc_bindist.py script
95c047a
@avdv
Format with black
c59e88d
@avdv
Determine GHC bindist versions from JSON file
b53a7c0
@avdv
Directly modify the JSON file and run gen_ghc_bindist.py
4125764 
When updating a GHC version, just add an empty entry for the version to the
`ghc_bindist_generated.json` file and run the gen_ghc_bindist.py to update it.
@avdv
Add GHC 9.8 to update-ghc workflow
a4b8b1e
@avdv avdv requested a review from ylecornec October 26, 2023 07:34
ylecornec
ylecornec approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@ylecornec ylecornec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 👍

@avdv avdv added the merge-queue merge on green CI label Nov 6, 2023
@avdv avdv merged commit 853d140 into master Nov 6, 2023
42 of 43 checks passed
@avdv avdv deleted the ghc-9.8 branch November 6, 2023 16:43
@mergify mergify bot removed the merge-queue merge on green CI label Nov 6, 2023
avdv added a commit that referenced this pull request Nov 7, 2023
@avdv
Fix extract_from_ghc_bindist.py
cf99bd6 
This was broken because of the refactoring in [#1999][1], we need to read the versions
from the `ghc_bindist_generated.json` file now.

[1]: #1999
@avdv avdv mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ylecornec ylecornec ylecornec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avdv @ylecornec