Fix Update GHC workflow #2258
Merged
Fix Update GHC workflow #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow failed for a few weeks because of an error:
```
Traceback (most recent call last):
File "/home/runner/work/rules_haskell/rules_haskell/haskell/gen_ghc_bindist.py", line 11, in <module>
from distutils.version import StrictVersion
ModuleNotFoundError: No module named 'distutils'
```
The `distutils` module is deprecated since Python 3.10 and has been removed in Python 3.12 now.
Apparently, this workflow is using Python 3.12 since the `nixpkgs` registry entry by default refers to
"github:NixOS/nixpkgs/nixpkgs-unstable".
This change uses the `packaging.version` module instead, switching to `nix-shell` to make use of the
nixpkgs revision that is configured in `nixpkgs/default.nix` and to provide the `packaging` pip package.
|
Note, running the "Update GHC" workflow (triggered manually) now is successful again: https://github.com/tweag/rules_haskell/actions/runs/11852416689 It found an update and created a PR here: #2259 |
ylecornec
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow failed for a few weeks because of an error:
The
distutilsmodule is deprecated since Python 3.10 and has been removed in Python 3.12 now.Apparently, this workflow is using Python 3.12 since the
nixpkgsregistry entry by default refers to"github:NixOS/nixpkgs/nixpkgs-unstable".
This change uses the
packaging.versionmodule instead, switching tonix-shellto make use of thenixpkgs revision that is configured in
nixpkgs/default.nixand to provide thepackagingpip package.