Merge pull request #354 from armanbilge/fix-353

Make flaky numeric test JVM-only
typelevel · Jul 7, 2021 · 503494a · 503494a
2 parents 1cf6adc + 3ffd299
commit 503494a
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 8 deletions.
diff --git a/...t/scala/jawn/ast/ParseCheckPlatform.scala → ...est/scala/jawn/ast/AstCheckPlatform.scala b/...t/scala/jawn/ast/ParseCheckPlatform.scala → ...est/scala/jawn/ast/AstCheckPlatform.scala
diff --git a/ast/js/src/test/scala/jawn/ast/AstTestPlatform.scala b/ast/js/src/test/scala/jawn/ast/AstTestPlatform.scala
@@ -0,0 +1,4 @@
+package org.typelevel.jawn
+package ast
+
+private[jawn] trait AstTestPlatform
diff --git a/...t/scala/jawn/ast/ParseCheckPlatform.scala → ...est/scala/jawn/ast/AstCheckPlatform.scala b/...t/scala/jawn/ast/ParseCheckPlatform.scala → ...est/scala/jawn/ast/AstCheckPlatform.scala
diff --git a/ast/jvm/src/test/scala/jawn/ast/AstTestPlatform.scala b/ast/jvm/src/test/scala/jawn/ast/AstTestPlatform.scala
@@ -0,0 +1,19 @@
+package org.typelevel.jawn
+package ast
+
+import org.scalacheck.Prop
+
+import Prop.forAll
+
+private[jawn] trait AstTestPlatform { self: AstTest =>
+
+  // See https://github.com/typelevel/jawn/issues/353
+
+  property(".getDouble") = forAll { (n: Double) =>
+    Prop(
+      JNum(n).getDouble == Some(n) &&
+        JParser.parseUnsafe(n.toString).getDouble == Some(n)
+    )
+  }
+
+}
diff --git a/...ared/src/test/scala/jawn/ParseCheck.scala → ...shared/src/test/scala/jawn/AstCheck.scala b/...ared/src/test/scala/jawn/ParseCheck.scala → ...shared/src/test/scala/jawn/AstCheck.scala
diff --git a/ast/shared/src/test/scala/jawn/AstTest.scala b/ast/shared/src/test/scala/jawn/AstTest.scala
@@ -7,7 +7,7 @@ import scala.util.{Success, Try}
 import ArbitraryUtil._
 import Prop.forAll
 
-class AstTest extends Properties("AstTest") {
+class AstTest extends Properties("AstTest") with AstTestPlatform {
 
   property("calling .get never crashes") = forAll { (v: JValue, s: String, i: Int) =>
     Prop(
@@ -48,13 +48,6 @@ class AstTest extends Properties("AstTest") {
     )
   }
 
-  property(".getDouble") = forAll { (n: Double) =>
-    Prop(
-      JNum(n).getDouble == Some(n) &&
-        JParser.parseUnsafe(n.toString).getDouble == Some(n)
-    )
-  }
-
   property(".getBigInt") = forAll { (n: BigInt) =>
     Prop(
       JNum(n.toString).getBigInt == Some(n) &&