Restructure build system to use Taskfile #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed deprecated syntax and introduced go modules support. Signed-off-by: Marvin Drees <[email protected]>
Initial commit to utilize the Taskfile buildsystem instead of GNU Make In addition: - Rebase kernel configs - Update License date - Reorder directory structure - Update gitignores accordingly - Update documentation accordingly - Update CircleCI accordingly Signed-off-by: Marvin Drees <[email protected]>
ChriMarMe
previously approved these changes
Sep 8, 2021
taskfiles/Proto.yml
Outdated
| cmds: | ||
| - protoc --go_out=plugins=grpc:. bmc.proto | ||
| - protoc --go_out=plugins=grpc:. config.proto | ||
|
|
There was a problem hiding this comment.
I think I was generally a bit inconsistent with newlines at the end of the Taskfiles, I'll clean that up later today then.
There was a problem hiding this comment.
My perception was wrong. Somehow the complaint was "No newline at end of file" and I interpreted that as "remove the line" Seems like it was complaining about the missing of it.
|
Good work! 👍 |
Signed-off-by: Marvin Drees <[email protected]>
ChriMarMe
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be a bit bigger. I completely restructured the way u-bmc is built and made the process more modular. With this approach it'll be easier to add future platforms and new SoCs to the source. The Go code remained untouched for now. It's also easier to track down errors in the build system and it's less fragile compared to GNU make in my opinion. This PR also requires #215 and solves #203 and also lays the ground to solve #204