Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curly braces to the if statement to pass checkstyle, although it's not necessary. #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

merrily01
Copy link

@merrily01 merrily01 commented Dec 8, 2020

What changes were proposed in this pull request?

  1. Add curly braces to the if statement to pass checkstyle, although it's not necessary.

  2. Add space after token if.

PS:This PR can be cherry-picked to spark30 branch.

Why are the changes needed?

In order to modify the code specification and pass the checkstyle.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Test is not needed.

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2020

CLA assistant check
All committers have signed the CLA.

@merrily01
Copy link
Author

@hiboyang @mabansal @vectorijk Can one of the admins verify this patch?

Please confirm whether it is necessary to merge, thx.

@merrily01
Copy link
Author

merrily01 commented Dec 15, 2020

Build Failed. The log is as follows:
image
It doesn't look like a problem with the project? @vectorijk

BTW: How to trigger rebuild by using Travis Ci ?

@merrily01 merrily01 closed this Jan 6, 2021
@merrily01 merrily01 reopened this Jan 6, 2021
@merrily01
Copy link
Author

merrily01 commented Jan 6, 2021

Hi~ @vectorijk @mabansal @hiboyang

Sorry to bother you,I found that the reason for Travis CI failure is that the external pull request cannot use the environment variable $ export FOSSA_API_KEY=[secure], see here.

So I wonder:

  1. How to deal with this situation?

  2. Does this project accept the PR from external contributors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants