Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: early share work towards experimental streaming support #173

Closed
wants to merge 4 commits into from

Conversation

jcorbin
Copy link
Contributor

@jcorbin jcorbin commented Jan 11, 2016

Much stil TODO:

  • break out and regression test the partial read fix to fragmentingReader
  • break out and finish the new ErrorHandlerFunc convenience
  • refactor the withArg2/withArg23 helpers added in client.go to be instead
    methods on tchannel.OutboundCallResponse
  • refactor the withArg2/withArg23 helpers added in server.go to be instead
    methods on tchannel.InboundCall
  • implement response coalescing under the server watch handler
  • implement error/cancellation support in the server watch handler
  • implement finer grained streaming timeout support: the context timeout
    should apply to only the first frame of a stream, with a separate longer
    timeout for the lifetime of the entire streamed request and/or response
    expressed as a request header (and then maybe modified by the initial
    response frame?)

cc @prashantv @nomis52

@jcorbin jcorbin force-pushed the josh_streaming_explore branch from 88f87fb to f5e4086 Compare January 19, 2016 22:41
@prashantv
Copy link
Contributor

Closing stale PR against master, filed #466 to fix this issue (and have a branch with a slightly different fix). However, since it doesn't affect any users it's not a high priority issue right now.

@prashantv prashantv closed this Jul 29, 2016
@prashantv prashantv deleted the josh_streaming_explore branch September 26, 2017 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants