Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add results from parameterized tests to parent #16

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Add results from parameterized tests to parent #16

merged 2 commits into from
Jul 2, 2024

Conversation

mnoah1
Copy link
Collaborator

@mnoah1 mnoah1 commented Jul 2, 2024 •
edited
Loading

This update will ensure that the correct test case gets updated when a parameterized test is run:

  • When test case results are sent back from the build server, a failure will be sent for each parameterized test case.
  • Extract the original test case name (language-specific), which will be used to lookup the correct parent item
  • Each entry, which contains the specific failure details for that entry, will now get added to the parent message. This will surface the specific cases in the parameterized test that failed.
    Example:
    image

@mnoah1 mnoah1 marked this pull request as ready for review July 2, 2024 13:40
@mnoah1 mnoah1 force-pushed the mnoah1/parameterized-results branch from 09495ee to f55a404 Compare July 2, 2024 20:13
@mnoah1 mnoah1 force-pushed the mnoah1/parameterized-results branch from f55a404 to ef38c73 Compare July 2, 2024 20:24
@mnoah1 mnoah1 merged commit ba94d71 into main Jul 2, 2024
4 checks passed
@mnoah1 mnoah1 deleted the mnoah1/parameterized-results branch July 2, 2024 20:40
@mnoah1 mnoah1 mentioned this pull request Jul 2, 2024
Merged
shuklahy pushed a commit that referenced this pull request Jul 2, 2024
@mnoah1
Release version 0.0.4 (#18)
f20826c 
## What's Changed
* Use readFile instead of openTextDocument for regex test case discovery
by @mnoah1 in #13
* Add getting started docs by @mnoah1 in
#12
* Adjust notifications during sync by @mnoah1 in
#14
* Show setup message when no targets returned from sync by @mnoah1 in
#15
* Adjustments to Python test discovery by @mnoah1 in
#17
* Add results from parameterized tests to parent by @mnoah1 in
#16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamyDev JamyDev JamyDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnoah1 @JamyDev