Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bazel-bsp default version #32

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

mnoah1
Copy link
Collaborator

@mnoah1 mnoah1 commented Jan 7, 2025

Updates the default bazel-bsp server version that gets installed by this extension. There is also a new feature flags data field in the initialization request that needs to be set here (currently only Python is behind a flag, Java is always enabled).

This version is necessary to support newly added debug support via the test explorer. With the newly added changes in #30, users that have a different version than the one specified will be auto-updated to the matching version.

Verified core extension workflows with this version:

  • Syncing test targets
  • Run with/without coverage
  • Run with debug

@mnoah1 mnoah1 force-pushed the update-bsp-server-version branch from f512e59 to 581d399 Compare January 7, 2025 20:59
@mnoah1 mnoah1 marked this pull request as ready for review January 7, 2025 21:05
Copy link
Collaborator

@shuklahy shuklahy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mnoah1 mnoah1 merged commit 1fa878f into uber:main Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants