-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an API for submitting sketches to a class #72 #145
Open
myqng
wants to merge
6
commits into
master
Choose a base branch
from
72-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1274cfe
api 72 take submissions
myqng dceae54
Added API for submitting sketches to a class
myqng 4500bf7
Added API for submitting sketches to a class
myqng 91a0f2e
Merge branch 'master' into 72-api
myqng 31a6865
Added API for submitting sketches to a class,
myqng 8e17a52
Merge branch '72-api' of https://github.com/uclaacm/teach-la-go-backe…
myqng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -219,3 +219,32 @@ func JoinClass(cc echo.Context) error { | |||||
|
||||||
return c.JSON(http.StatusOK, class) | ||||||
} | ||||||
|
||||||
func SubmitAssignment(cc echo.Context) error { | ||||||
req := struct { | ||||||
submissionPID string `json:"submissionPID"`// PID of the program being submitted | ||||||
assignmentPID string `json:"assignmentPID"` // PID of the program/assignment this is being submitted to. Potentially optional | ||||||
uid string `json:"uid"` // UID of the submitting user | ||||||
cid string `json:"cid"` // Class ID | ||||||
}{} | ||||||
|
||||||
c := cc.(*db.DBContext) | ||||||
|
||||||
// read JSON from request body | ||||||
if err := httpext.RequestBodyTo(c.Request(), &req); err != nil { | ||||||
return c.String(http.StatusInternalServerError, err.Error()) | ||||||
} | ||||||
if req.submissionPID.uid == "" { | ||||||
return c.String(http.StatusBadRequest, "submission PID is required") | ||||||
} | ||||||
if req.assignmentPID.uid == "" { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
return c.String(http.StatusBadRequest, "assignment PID is required") | ||||||
} | ||||||
if req.uid == "" { | ||||||
return c.String(http.StatusBadRequest, "uid is required") | ||||||
} | ||||||
if req.cid == "" { | ||||||
return c.String(http.StatusBadRequest, "cid is required") | ||||||
} | ||||||
return nil | ||||||
} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For now, if you just add |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.