Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-421 Implement types and permissions #185

Merged
merged 1 commit into from
May 6, 2020
Merged

Conversation

SebCorbin
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Apr 27, 2020

Pull Request Test Coverage Report for Build 1901

  • 55 of 56 (98.21%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 90.596%

Changes Missing Coverage Covered Lines Changed/Added Lines %
perms/partnership_perms.py 12 13 92.31%
Totals Coverage Status
Change from base Build 1899: 0.04%
Covered Lines: 3102
Relevant Lines: 3424

💛 - Coveralls

@SebCorbin SebCorbin marked this pull request as draft April 28, 2020 08:33
@SebCorbin SebCorbin force-pushed the technical/op-381 branch 2 times, most recently from 2135e27 to 91ba1dd Compare May 4, 2020 10:03
@SebCorbin SebCorbin requested a review from albrugnetti May 4, 2020 12:07
filter.py Show resolved Hide resolved
migrations/0053_domain_isced_migration.py Outdated Show resolved Hide resolved
models/partnership/partnership.py Outdated Show resolved Hide resolved
perms/partnership_perms.py Show resolved Hide resolved
urls.py Show resolved Hide resolved
@SebCorbin SebCorbin force-pushed the op-421 branch 2 times, most recently from 82608d9 to 866507b Compare May 5, 2020 11:49
@SebCorbin SebCorbin force-pushed the technical/op-381 branch from 91ba1dd to 0a5ffc6 Compare May 6, 2020 08:57
@SebCorbin SebCorbin requested a review from albrugnetti May 6, 2020 09:12
@SebCorbin SebCorbin marked this pull request as ready for review May 6, 2020 09:12
from partnership.models import PartnershipType


class PartnershipTypeConverter:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi as-tu besoin de la classe PartnershipTypeConverter ?

@albrugnetti albrugnetti merged commit 31f46d4 into technical/op-381 May 6, 2020
@albrugnetti albrugnetti deleted the op-421 branch May 6, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants