fix: 🚑️ Fix two issues introduced by breadcrumbs changes

The breadcrumbs change added a child element to the `wp-blocks` container. In it's grid template style rule, we only accounted for three children, not four. This change fixes that, and adjusts the breadcrumbs parent element from `div` to `section` in the templates
ucsc · Apr 12, 2024 · c311b4f · c311b4f
1 parent 8478f03
commit c311b4f
Show file tree

Hide file tree

Showing 10 changed files with 22 additions and 18 deletions.
diff --git a/src/scss/base/_layout.scss b/src/scss/base/_layout.scss
@@ -12,6 +12,10 @@ body {
 	flex: 1 0 auto;
 	display: grid;
 	grid-template-rows: auto 1fr auto;
+
+	&:has(.breadcrumbs-region) {
+		grid-template-rows: auto auto 1fr auto;
+	}
 }
 
 .editor-styles-wrapper {

diff --git a/templates/404.html b/templates/404.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","className":"content-region","layout":{"inherit":true}} -->
 <main class="wp-block-group content-region">
@@ -27,4 +27,4 @@ <h1 class="entry-title">
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
diff --git a/templates/archive.html b/templates/archive.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","style":{"spacing":{"margin":{"top":"var:preset|spacing|50"}}},"className":"content-region","layout":{"inherit":true}} -->
 <main class="wp-block-group content-region" style="margin-top:var(--wp--preset--spacing--50)">
@@ -11,4 +11,4 @@
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
diff --git a/templates/category.html b/templates/category.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","className":"content-region","layout":{"inherit":true,"type":"constrained"}} -->
 <main class="wp-block-group content-region">
@@ -23,4 +23,4 @@
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
diff --git a/templates/home.html b/templates/home.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","className":"content-region","layout":{"inherit":true,"type":"constrained"}} -->
 <main class="wp-block-group content-region">
@@ -28,4 +28,4 @@
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
diff --git a/templates/index.html b/templates/index.html
@@ -1,10 +1,10 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","style":{"spacing":{"margin":{"top":"var:preset|spacing|50"}}},"className":"content-region"} -->
 <main class="wp-block-group content-region" style="margin-top:var(--wp--preset--spacing--50)">
 	<!-- wp:post-content {"layout":{"type":"constrained"}} /-->
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
diff --git a/templates/page-no-title.html b/templates/page-no-title.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main", "className":"content-region"} -->
 <main class="wp-block-group content-region">
@@ -9,4 +9,4 @@
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
diff --git a/templates/page.html b/templates/page.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","style":{"spacing":{"margin":{"top":"var:preset|spacing|40"}}},"className":"content-region"} -->
 <main class="wp-block-group content-region" style="margin-top:var(--wp--preset--spacing--40)">
@@ -15,4 +15,4 @@
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
diff --git a/templates/search.html b/templates/search.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","className":"content-region"} -->
 <main class="wp-block-group content-region">
@@ -17,4 +17,4 @@
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
diff --git a/templates/single.html b/templates/single.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","className":"content-region","layout":{"type":"default"}} -->
 <main class="wp-block-group content-region">
@@ -67,4 +67,4 @@
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->