-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
129 decrease size of braintool docker image #132
129 decrease size of braintool docker image #132
Conversation
@Ivan-E-Johnson @zmorris248 @powersaudrey25 the new example_tool_light is a copy of example_tool with limited functionality. For the purpose of easy switching between the two (which will be important especially in the AWS deployment) I propose to ignore the SonarCloud error |
delete most of dependency packages from requirements file remove part of default itk install
ADD: add the missing study id FIX: change example data directory
3ff6171
to
8f623f3
Compare
I agree with Michal on ignoring the sonarcloud error. This looks good Michal! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@mbrzus @zmorris248 I dont see a way on sonar cloud to disable the check so we may need to do this on github. Do you want me to disable the rule on github merge and then reenable it? |
@Ivan-E-Johnson I think that is the best way to go about this since it is a unique situation. I didn't find an easy way to do it either. |
I created a new quality gate on sonarcloud that doesn't check for duplication I am go to try and run this pr with it now |
Quality Gate passedIssues Measures |
we can switch back to our other quality gate whenever we want |
@mbrzus When I build the exampletool light docker and run the script to run it, I get the following error: Do you know what this could be? |
I will need more info. do you run the docker only or are you running it from within the Orthanc Receiver Agent? |
Overview
This pull requests creates "light" version of the example tool to reduce the environment dependencies from 6.7 GB to 849 MB.
Currently, the tool still performs the DICOM data checking and sanitization but produces empty report. However, it still encodes the report to the DICOM format thus maintaining the full functionality from data types and delivery items.
This changed required restructurization of the repo by moving the example data to the base level to avoid duplicating it.
Implementation
Testing
Testing should be performed the same way as the example_tool
Closes #129