Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

129 decrease size of braintool docker image #132

Merged
merged 20 commits into from
Mar 6, 2024

Conversation

mbrzus
Copy link
Contributor

@mbrzus mbrzus commented Mar 5, 2024

Overview

This pull requests creates "light" version of the example tool to reduce the environment dependencies from 6.7 GB to 849 MB.

Currently, the tool still performs the DICOM data checking and sanitization but produces empty report. However, it still encodes the report to the DICOM format thus maintaining the full functionality from data types and delivery items.

This changed required restructurization of the repo by moving the example data to the base level to avoid duplicating it.

Implementation

  • removed the functionality related to the actual image processing which allowed for removal of large AI related dependencies.
  • create docker related files for the light version of the example tool
  • move data to base level

Testing

Testing should be performed the same way as the example_tool

Closes #129

@mbrzus mbrzus linked an issue Mar 5, 2024 that may be closed by this pull request
@mbrzus
Copy link
Contributor Author

mbrzus commented Mar 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions 45.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Ivan-E-Johnson @zmorris248 @powersaudrey25 the new example_tool_light is a copy of example_tool with limited functionality. For the purpose of easy switching between the two (which will be important especially in the AWS deployment) I propose to ignore the SonarCloud error

@mbrzus mbrzus force-pushed the 129-decrease-size-of-braintool-docker-image branch from 3ff6171 to 8f623f3 Compare March 6, 2024 03:24
@zmorris248
Copy link
Contributor

I agree with Michal on ignoring the sonarcloud error. This looks good Michal!

Copy link
Contributor

@Ivan-E-Johnson Ivan-E-Johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Ivan-E-Johnson
Copy link
Contributor

@mbrzus @zmorris248 I dont see a way on sonar cloud to disable the check so we may need to do this on github. Do you want me to disable the rule on github merge and then reenable it?

@zmorris248
Copy link
Contributor

zmorris248 commented Mar 6, 2024

@Ivan-E-Johnson I think that is the best way to go about this since it is a unique situation. I didn't find an easy way to do it either.

@powersaudrey25
Copy link
Contributor

I created a new quality gate on sonarcloud that doesn't check for duplication I am go to try and run this pr with it now

Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
35.0% Duplication on New Code

See analysis details on SonarCloud

@powersaudrey25
Copy link
Contributor

I created a new quality gate on sonarcloud that doesn't check for duplication I am go to try and run this pr with it now

we can switch back to our other quality gate whenever we want

@zmorris248
Copy link
Contributor

@mbrzus When I build the exampletool light docker and run the script to run it, I get the following error:
docker: Error response from daemon: pull access denied for brainmasktool, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.

Do you know what this could be?

@mbrzus
Copy link
Contributor Author

mbrzus commented Mar 6, 2024

@mbrzus When I build the exampletool light docker and run the script to run it, I get the following error: docker: Error response from daemon: pull access denied for brainmasktool, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.

Do you know what this could be?

I will need more info. do you run the docker only or are you running it from within the Orthanc Receiver Agent?

@Ivan-E-Johnson Ivan-E-Johnson merged commit adf3af0 into main Mar 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decrease Size of BrainTool Docker Image
4 participants