Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

173 cleanup #187

Merged
merged 81 commits into from
May 2, 2024
Merged

173 cleanup #187

merged 81 commits into from
May 2, 2024

Conversation

zmorris248
Copy link
Contributor

Overview

This PR enables full system deployment and functionality on Amazon Web Services (AWS) using the Elastic Kubernetes Service (EKS). It ensures that our application can operate seamlessly in a cloud environment, catering to the demands of scalable infrastructure.

Implementation

This implementation primarily focuses on configuring AWS systems, including network settings, service subnets, and other essential cloud components. Key updates include:

  • Network Configuration: Setup of VPCs, subnets, and security groups to ensure secure and efficient network traffic.
  • Script Modifications: Adjustments in deployment scripts to enhance performance and resolve minor issues.
  • Orthanc-PACS Integration: System setup adjustments for internal Orthanc to communicate effectively with external third-party PACS systems.

Testing

Testing was conducted through comprehensive manual checks to validate the functionality of each component and the system as a whole. Specific focus areas included:

  • Manual System Verification: Ensuring that all components work as expected within the AWS environment.
  • Integration Testing: Checking the integration points, especially the connectivity between Orthanc and PACS systems, to verify data flow and functionality.

Problems Faced

Several challenges were encountered during the implementation, particularly with network connectivity and HTTPS protocol handling between Kubernetes pods. Key issues included:

  • Proxy Network Issues: Difficulty in external system connectivity due to university proxy settings.
  • Resolution: Implemented a simulated hospital PACS system on AWS to bypass the proxy limitations, ensuring reliable external communications.

This pull request lays the groundwork for a robust and scalable deployment of our system in a cloud environment, addressing past connectivity issues and streamlining operations.

aws_cluster/listening/receiver_deployment.yaml Dismissed Show dismissed Hide dismissed
aws_cluster/frontend/aws_frontend_kube_deployment.yaml Dismissed Show dismissed Hide dismissed
postgres_kube_persistantvolume_statefulset.yaml Dismissed Show dismissed Hide dismissed
eks_tutorial/eks_sample_deployment.yaml Dismissed Show dismissed Hide dismissed
eks_tutorial/eks_sample_deployment.yaml Dismissed Show dismissed Hide dismissed
eks_tutorial/eks_sample_deployment.yaml Dismissed Show dismissed Hide dismissed
Copy link

github-actions bot commented May 2, 2024

Jest Coverage

Summary

Lines Statements Branches Functions
Coverage: 72%
73.27% (521/711) 56.8% (96/169) 65.74% (142/216)

Junit Summary

Tests Skipped Failures Errors Time
37 0 💤 0 ❌ 0 🔥 3.833s ⏱️
Coverage Report (72%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files73.2756.865.7472.08 
fixtures100100100100 
   hospitalFixture.tsx100100100100 
   kidneyStudyFixture.tsx100100100100 
   providerFixture.tsx100100100100 
src/components90.9944.4489.6591.17 
   ErrorMessageBox.tsx100100100100 
   EventTimeline.tsx71.42007579–83
   Metadata.tsx85.7108084.6174–75
   Navbar.tsx90.475010090150, 163
   StackedChart.tsx10066.6610010072–85
   withAuthenticated.tsx100100100100 
src/contexts9010058.3389.28 
   authContext.tsx9010058.3389.2872, 90, 104
src/data30.9315.3833.8720 
   index.ts30.9315.3833.872017–27, 38–48, 59–69, 80–90, 98–108, 118–128, 140–149, 161–171, 181–190, 200–205, 217–240, 251–259, 269–274, 287–326, 335–345, 355–365, 370–380, 385–395, 411–412
src/hooks100100100100 
   useAuthContext.ts100100100100 
src/pages81.7267.2780.3982.01 
   analytics.tsx96.1510088.889690
   dashboard.tsx100100100100 
   index.tsx100100100100 
   login.tsx83.8788.8885.7183.3352–57, 109
   profile.tsx77.561.538080.5559–61, 83–86
   signup.tsx71.6255.5566.6671.2389–91, 98–100, 116–140, 224–231, 270–287
src/pages/apikeys73.2154.5464.2871.69 
   index.tsx73.2154.5464.2871.6974–77, 89, 94–99, 104–108, 195
src/pages/studies79.3157.1472.9781.34 
   [id].tsx69.0137.557.8971.8785, 94–108, 112–114, 125–126, 130, 134, 143, 219
   index.tsx89.1871.8788.889049, 64, 111, 120, 127, 141, 149

ivanjohnson-lab and others added 25 commits May 2, 2024 11:15
Seems like there are multiple container types that are not supported
…be deployed as EC2 instead"

This reverts commit a4df66e.
Currently failing to pull the image
the goal is to source aws_common_resources to dry out code
and to reduce liklyhood of naming missmatch
Can extend this for all needed images we need to build
ivanjohnson-lab and others added 16 commits May 2, 2024 11:15
This is due to us not having any current customers
Since we want to make the tcp socket connections we need to use a Network load Blancer instead of the Application load balancerd
This hsold allow us to create and push all needed images
Previously we were making id's strictly based on our study id but we need to extend this funcitonality to allow for the same study to be processed multiple times
This was the last straw in what needs for deployment
Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
19 New issues
11 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
50.5% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@powersaudrey25 powersaudrey25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic work thanks guys!

@zmorris248 zmorris248 merged commit ddebf2c into main May 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants