Ruff #45
Merged
Ruff #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan-E-Johnson
added
enhancement
|
@Ivan-E-Johnson ruff removed the init.py files from the backend and doing that screwed up all the imports. I excluded a file with init from ruff. We now have one test failing, not sure why running ruff would cause a unit test to fail. |
BUG: IM Stupid and made a mistake
BUG: adding import BUG: updating imports for alembic BUG: updating config import for alembic Revert "BUG: adding import" This reverts commit 5a158bc. FIX: merge conflict Revert "BUG: updating config import for alembic" This reverts commit 41a7f7a BUG: reverting imports and ignore __init__ for ruff WIP: trying a different way of formatting WIP: add two more files to exclude WIP: going back to just excluding init
|
mbrzus
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add ruff to the precommits and update the code base to be conformant with ruff
Implementation
Testing (Manual)
NA
Testing (Automated)
NA
Screenshots