fix lint and update go version

.github/workflows/go.yml

@@ -8,10 +8,10 @@ jobs:
       - name: Check out code into the Go module directory
         uses: actions/checkout@v1
 
-      - name: Set up Go 1.19
+      - name: Set up Go 1.21
         uses: actions/setup-go@v3
         with:
-          go-version: 1.19
+          go-version: 1.21
         id: go
 
       - name: Libraries for gio

README.md

@@ -56,7 +56,7 @@ the supported instant exchange are: [trocador](https://trocador.app/),
 
 For taking the api keys. Please go to the instant exchange websites
 
-Note: You need to have [Go 1.19](https://golang.org/dl/) or above to build.
+Note: You need to have [Go 1.21](https://golang.org/dl/) or above to build.
 
 Then `go build`.
 

app/widgetdisplaypage.go

@@ -24,7 +24,7 @@ func NewWidgetDisplayPage(widget layout.Widget) *WidgetDisplayPage {
 func (*WidgetDisplayPage) OnNavigatedTo() {}
 
 // HandleUserInteractions implements Page.
-func (*WidgetDisplayPage) HandleUserInteractions(gtx layout.Context) {}
+func (*WidgetDisplayPage) HandleUserInteractions(_ layout.Context) {}
 
 // Layout implements Page.
 func (pg *WidgetDisplayPage) Layout(gtx layout.Context) layout.Dimensions {

app/window_test.go

@@ -93,7 +93,7 @@ func (tPage *testPage) OnNavigatedTo() {
 	tPage.calledMethod(pageMethodOnNavigatedTo)
 }
 
-func (tPage *testPage) HandleUserInteractions(gtx layout.Context) {
+func (tPage *testPage) HandleUserInteractions(_ layout.Context) {
 	tPage.calledMethod(pageMethodHandleUserInteractions)
 }
 
@@ -190,7 +190,7 @@ func (tModal *testModal) OnResume() {
 	tModal.calledMethod(modalMethodOnResume)
 }
 
-func (tModal *testModal) Handle(gtx layout.Context) {
+func (tModal *testModal) Handle(_ layout.Context) {
 	tModal.calledMethod(modalMethodHandle)
 }
 

libwallet/libwallet_suite_test.go

@@ -10,6 +10,6 @@ import (
 
 func TestLibwallet(t *testing.T) {
 	gomega.RegisterFailHandler(ginkgo.Fail)
-	rand.Seed(ginkgo.GinkgoRandomSeed())
+	rand.New(rand.NewSource(ginkgo.GinkgoRandomSeed()))
 	ginkgo.RunSpecs(t, "Libwallet Suite")
 }

ui/cryptomaterial/progressbar.go

@@ -147,10 +147,10 @@ func (p ProgressBarStyle) Layout(gtx C) D {
 
 	progressBarWidth := int(p.Width)
 	return layout.Stack{Alignment: layout.W}.Layout(gtx,
-		layout.Stacked(func(gtx C) D {
+		layout.Stacked(func(_ C) D {
 			return shader(progressBarWidth, p.TrackColor)
 		}),
-		layout.Stacked(func(gtx C) D {
+		layout.Stacked(func(_ C) D {
 			fillWidth := int(float32(progressBarWidth) * clamp1(p.Progress))
 			fillColor := p.Color
 			fillColor = Disabled(fillColor)

ui/cryptomaterial/theme.go

@@ -271,7 +271,7 @@ func approxLuminance(c color.NRGBA) byte {
 	return byte((r*int(c.R) + g*int(c.G) + b*int(c.B)) / t)
 }
 
-func HandleEditorEvents(gtx C, editors ...*Editor) (bool, bool) {
+func HandleEditorEvents(_ C, editors ...*Editor) (bool, bool) {
 	var submit, changed bool
 	for _, editor := range editors {
 		submit = submit || editor.Submitted()

ui/page/components/votebar_widget.go

@@ -187,8 +187,7 @@ func (v *VoteBar) votesIndicatorTooltip(gtx C, r image.Rectangle, tipPos float32
 	inset := layout.Inset{Left: gtx.Metric.PxToDp(int(insetLeft)), Top: values.MarginPadding25}
 	v.passTooltip.Layout(gtx, r, inset, func(gtx C) D {
 		txt := values.StringF(values.StrVoteTooltip, int(v.passPercentage))
-		cap := v.Theme.Caption(txt).Layout(gtx)
-		return cap
+		return v.Theme.Caption(txt).Layout(gtx)
 	})
 }
 

ui/page/governance/proposals_page.go

@@ -221,7 +221,7 @@ func (pg *ProposalsPage) HandleUserInteractions(gtx C) {
 	}
 
 	for pg.syncButton.Clicked(gtx) {
-		go func() { pg.AssetsManager.Politeia.Sync(context.Background()) }()
+		go func() { _ = pg.AssetsManager.Politeia.Sync(context.Background()) }()
 		pg.isSyncing = true
 
 		// TODO: check after 1min if sync does not start, set isSyncing to false and cancel sync

ui/page/security/sign_message_page.go

@@ -301,7 +301,7 @@ func (pg *SignMessagePage) handleEditorEvents(gtx C) {
 // used to update the page's UI components shortly before they are
 // displayed.
 // Part of the load.Page interface.
-func (pg *SignMessagePage) HandleUserInteractions(gtx C) {
+func (pg *SignMessagePage) HandleUserInteractions(_ C) {
 	pg.updateButtonColors()
 }
 

ui/page/settings/log_page.go

@@ -198,7 +198,7 @@ func (pg *LogPage) layoutMobile(gtx layout.Context) layout.Dimensions {
 // used to update the page's UI components shortly before they are
 // displayed.
 // Part of the load.Page interface.
-func (pg *LogPage) HandleUserInteractions(gtx C) {}
+func (pg *LogPage) HandleUserInteractions(_ C) {}
 
 // OnNavigatedFrom is called when the page is about to be removed from
 // the displayed window. This method should ideally be used to disable

ui/page/settings/statistics_page.go

@@ -227,7 +227,7 @@ func (pg *StatPage) appStartTime() {
 // used to update the page's UI components shortly before they are
 // displayed.
 // Part of the load.Page interface.
-func (pg *StatPage) HandleUserInteractions(gtx C) {
+func (pg *StatPage) HandleUserInteractions(_ C) {
 	pg.appStartTime()
 }