Add layouts to the DWDS #663
Open
+77
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CamLamb
force-pushed
the
pattern-lib-bookmarks
branch
from
f1e73ee to
a18f02b
Compare
CamLamb
force-pushed
the
pattern-lib-dwds-layouts
branch
from
ddc33c4 to
05c64fe
Compare
CamLamb
force-pushed
the
pattern-lib-bookmarks
branch
from
a18f02b to
ae80aeb
Compare
CamLamb
force-pushed
the
pattern-lib-dwds-layouts
branch
from
05c64fe to
848b72d
Compare
CamLamb
changed the base branch from
pattern-lib-bookmarks
to
pattern-lib-restructure
CamLamb
changed the title
CamLamb
force-pushed
the
pattern-lib-dwds-layouts
branch
from
848b72d to
4a5be82
Compare
|
I've got quite a lot of feedback about this, and wouldn't mind a discussion. Top of the list though, is I don't think we will be sticking with anything 1 col most likely, and I think our layouts will be becoming more diverse. I don't think naming 1_col and 2_col is forward thinking in that context. Also, I'm not totally convinced we need or want the layouts inside the DS, as opposed to in Either way please hold off this until it's been chatted about with the team :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.