Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTR-496: Apply styling for bookmark #854

Merged
merged 4 commits into from
Jan 13, 2025
Merged

INTR-496: Apply styling for bookmark #854

merged 4 commits into from
Jan 13, 2025

Conversation

smanga24
Copy link
Contributor

@smanga24 smanga24 commented Jan 8, 2025 •
edited
Loading

  • JIRA ticket referenced in title
  • Title is clear and concise
  • Description gives any relevant detail
  • Tests are up to date
  • Documentation is up to date
    image

@smanga24 smanga24 requested a review from a team as a code owner January 8, 2025 18:15
@smanga24 smanga24 requested review from oyeniyipa and removed request for a team January 8, 2025 18:15
@smanga24 smanga24 force-pushed the INTR-496-bookmark-styling branch 2 times, most recently from 19779f9 to 8f999b4 Compare January 9, 2025 15:41
@smanga24 smanga24 requested a review from a team as a code owner January 9, 2025 15:41
@smanga24 smanga24 requested a review from nicopicchio January 9, 2025 15:41
nicopicchio
nicopicchio reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@nicopicchio nicopicchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please post a screenshot of the final result in the PR description?

src/dw_design_system/dwds/styles/variables.scss Outdated Show resolved Hide resolved
@smanga24
Copy link
Contributor Author

smanga24 commented Jan 9, 2025

can you please post a screenshot of the final result in the PR description?

attached screenshot

@CamLamb CamLamb changed the title INTR-496: Apply stylying for bookmark INTR-496: Apply styling for bookmark Jan 10, 2025
@smanga24 smanga24 force-pushed the INTR-496-bookmark-styling branch from 5486382 to d0f3d87 Compare January 13, 2025 14:34
@smanga24 smanga24 added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit d2c4d29 Jan 13, 2025
4 checks passed
@smanga24 smanga24 deleted the INTR-496-bookmark-styling branch January 13, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicopicchio nicopicchio nicopicchio left review comments

@CamLamb CamLamb CamLamb approved these changes

@oyeniyipa oyeniyipa Awaiting requested review from oyeniyipa oyeniyipa was automatically assigned from uktrade/employee-experience

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smanga24 @CamLamb @nicopicchio