LTD-5812-file-upload-validation #2322
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depsiatwal
force-pushed
the
LTD-5812-file-upload-validation
branch
3 times, most recently
from
c982fd3 to
3cb5cb1
Compare
depsiatwal
force-pushed
the
LTD-5812-file-upload-validation
branch
3 times, most recently
from
6aee124 to
b2c0a27
Compare
depsiatwal
commented
Jan 22, 2025
| @@ -62,7 +62,10 @@ def receive_data_chunk(self, raw_data, start): | |||
| mime = magic.from_buffer(raw_data, mime=True) | |||
| if mime not in self.ACCEPTED_FILE_UPLOAD_MIME_TYPES: | |||
| self.abort() | |||
| raise UnacceptableMimeTypeError(f"Unsupported file type: {mime}") | |||
| # Raise StopUpload signals the django multipartparser to exhaust the stream and stops the upload | |||
| exception = UnacceptableMimeTypeError(f"Unsupported file type: {mime}") | |||
There was a problem hiding this comment.
SkipUpload halts the upload which is good practice as it prevents non supported file types being uploaded to S3.
As a result the calling form will not receive the file and sees an empty FileInput.
depsiatwal
commented
Jan 22, 2025
| raise UnacceptableMimeTypeError(f"Unsupported file type: {mime}") | ||
| # Raise StopUpload signals the django multipartparser to exhaust the stream and stops the upload | ||
| exception = UnacceptableMimeTypeError(f"Unsupported file type: {mime}") | ||
| logger.error(exception) |
There was a problem hiding this comment.
We now log the error since the django multipartparser will swallow this exception.
depsiatwal
force-pushed
the
LTD-5812-file-upload-validation
branch
from
b2c0a27 to
ee9e36a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://uktrade.atlassian.net/browse/LTD-5812
Current changes --
The file handler SafeS3FileUploadHandler now raises an exception that inherits from StopUpload this forces to halt the upload.
https://github.com/django/django/blob/64b1ac7292c72d3551b2ad70b2a78c8fe4af3249/django/http/multipartparser.py#L674
The form which requested the file will receive no file in the post request. Hence the following are supported
Previously there was a mismatch between 1 and 2. Also in Scenario 1 the usee would see a 500 error resulting in generic Service error.
Since the fileupload hander Halts the upload operation there appears to be no easy route to signal this to the view.
Checking Form data will be blank since no file has been upload , alternatively I tired intercepting in the middleware
request.FILES is always empty due to the file upload being halted. Have also tried form validation methods however the clean method for the field is empty as no file has been uploaded.