Skip to content

Commit

Permalink
lint
Browse files Browse the repository at this point in the history
  • Loading branch information
unRob committed Sep 6, 2022
1 parent 6fc28c0 commit 7d5f5e1
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .milpa/docs/milpa/use-case.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Here's some examples of how I've used used `milpa` so far:

- for **managing homelab services** (i.e. [unRob/nidito](https://github.com/unRob/nidito/tree/master/.milpa)): building and deploying them, looking at their status and logs. From my personal device or CI.
- **bootstrapping engineering laptops** (i.e. [unRob/dotfiles](https://github.com/unRob/dotfiles/tree/master/.milpa/commands/computar)): no need to follow a README, you get the right development environment for your os/arch, your credentials setup and the code ready for you to dive in.
- **every-day dev workflow**: connect to vpn, get credentials to resources, maybe `--connect` to them, abstract away APIs (internal, cloud provider and SaaS) and CLIs, toggle feature gates, build reports and update google sheets with the results.
- **every-day dev workflow** (i.e. [unrRob/milpa](https://github.com/unRob/milpa/tree/main/repos/internal/commands/)): lint and test a codebase, connect to vpn, get credentials to resources, maybe `--connect` to them, abstract away APIs (internal, cloud provider and SaaS) and CLIs, toggle feature gates, build reports and update google sheets with the results.
- as a way to organize all those odd, one-off-but-not-really commands: found a nice home for [shell scripts](https://github.com/unRob/dotfiles/blob/master/.milpa/commands/code/todo.sh), quick ruby scripts, perl hacks and [jq monstrosities](https://github.com/unRob/dotfiles/blob/master/.milpa/commands/creds.sh) that used to live in my `~/.zsh_history`.

I found `milpa` useful for these particular problems, since it only requires Bash and a supported OS/arch. `milpa` helps setup the computers I use (directly or remotely) and makes working with whatever languages my employer prefers (today and beyond) a breeze to integrate into a cohesive set of scripts. `milpa` does the work of parsing arguments, validating them, offering help when things go sideways and so on, so these small scripts remain just so: small scripts.
Expand Down
4 changes: 2 additions & 2 deletions internal/command/help.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ func (cmd *Command) ShowHelp(globalOptions Options, args []string) ([]byte, erro

colorEnabled := runtime.ColorEnabled()
flags := cmd.cc.Flags()
ncf := cmd.cc.Flag("no-color")
cf := cmd.cc.Flag("color")
ncf := cmd.cc.Flag("no-color") // nolint:ifshort
cf := cmd.cc.Flag("color") // nolint:ifshort

if noColorFlag, err := flags.GetBool("no-color"); err == nil && ncf.Changed {
colorEnabled = !noColorFlag
Expand Down
2 changes: 1 addition & 1 deletion repos/internal/commands/dev/setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ fi
packages=(
gotest.tools/[email protected]
github.com/mitchellh/[email protected]
github.com/golangci/golangci-lint/cmd/[email protected].2
github.com/golangci/golangci-lint/cmd/[email protected].3
)

for package in "${packages[@]}"; do
Expand Down

0 comments on commit 7d5f5e1

Please sign in to comment.