Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(textbox + textblock): TextBox Undo/Redo, TextBlock selection, rendering fixes and major cleanup #14371

Merged
merged 29 commits into from
Dec 20, 2023
Merged

feat(textbox + textblock): TextBox Undo/Redo, TextBlock selection, rendering fixes and major cleanup #14371

merged 29 commits into from
Dec 20, 2023

Conversation

ramezgerges
Copy link
Contributor

@ramezgerges ramezgerges commented Nov 9, 2023 •
edited by MartinZikmund
Loading

GitHub Issue (If applicable): #9417, closes #14415

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

What is the new behavior?

Copilot Summary

🤖 Generated by Copilot at 5684f14

This pull request enhances the TextBox control on various platforms by fixing bugs, improving performance, and adding password masking support. It modifies the TextBox.cs and InlineCollection.skia.cs files.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform labels Nov 9, 2023
jeromelaban
jeromelaban reviewed Nov 14, 2023
View reviewed changes
src/Uno.UI.Runtime.Skia.Gtk/Input/GtkCorePointerInputSource.cs Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Controls/TextBlock/TextBlock.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Controls/TextBlock/TextBlock.iOSmacOS.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.cs Outdated Show resolved Hide resolved
src/Uno.UWP/UI/Input/Preview.Injection/InputInjector.cs Outdated Show resolved Hide resolved
src/Uno.UWP/UI/Input/Preview.Injection/InputInjector.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.skia.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.skia.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.skia.cs Outdated Show resolved Hide resolved
@jeromelaban jeromelaban marked this pull request as draft November 14, 2023 14:28
@ramezgerges ramezgerges mentioned this pull request Nov 14, 2023
Open
44 tasks
@github-actions github-actions bot removed platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform labels Nov 17, 2023
@ramezgerges ramezgerges changed the title feat(textbox): Undo/Redo,rendering fixes feat(textbox + textblock): TextBox Undo/Redo, TextBlock selection, rendering fixes and major cleanup Nov 22, 2023
@unodevops
Copy link
Contributor

🤖 Your docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14371/index.html

@unodevops
Copy link
Contributor

🤖 Your docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14371/index.html

@jeromelaban
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14371/index.html

@jeromelaban
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-14371/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14371/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14371/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-14371/index.html

@jeromelaban
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-14371/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14371/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-14371/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14371/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-14371/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14371/index.html

@MartinZikmund MartinZikmund merged commit 84d6aaa into unoplatform:master Dec 20, 2023
86 checks passed
lindexi added a commit to lindexi/uno that referenced this pull request May 10, 2024
@lindexi
perf(wpf): Replace Reflection with PInovke win32 in WpfKeyboardInputS…
a851109 
…ource

unoplatform#14371
@lindexi lindexi mentioned this pull request May 10, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindexi lindexi lindexi left review comments

@dr1rrb dr1rrb dr1rrb left review comments

@jeromelaban jeromelaban jeromelaban left review comments

@MartinZikmund MartinZikmund MartinZikmund approved these changes

Assignees
No one assigned
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Skia] TextBox Undo/redo support [Skia] TextBlock text selection support
6 participants
@ramezgerges @unodevops @jeromelaban @MartinZikmund @dr1rrb @lindexi