Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCES-10 urd login page #19

Merged
merged 22 commits into from
Nov 5, 2023
Merged

TCES-10 urd login page #19

merged 22 commits into from
Nov 5, 2023

Conversation

3milyfz
Copy link
Member

@3milyfz 3milyfz commented Oct 27, 2023 •
edited
Loading

Description

  • Added login component according to Figma mockup
  • Design approval from Jake is pending

Completed TCES-10

image image

@linear
Copy link

linear bot commented Oct 27, 2023

TCES-10 URD-Login Page

Users need a page to be able to login from!

Completion Requirements:

  • Make the page look the same as the figma design
  • Get approval from Jake

@3milyfz 3milyfz self-assigned this Oct 27, 2023
@3milyfz 3milyfz added Frontend Any Frontend Changes and removed Frontend Any Frontend Changes labels Oct 28, 2023
DanielDervishi
DanielDervishi reviewed Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@DanielDervishi DanielDervishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- Thanks Emily! I only left a single comment which should be a quick fix :)

client/.prettierrc.json Outdated Show resolved Hide resolved
jordanjanakievski
jordanjanakievski reviewed Nov 1, 2023
View reviewed changes
client/src/components/Login.jsx Outdated Show resolved Hide resolved
client/src/components/Login.jsx Outdated Show resolved Hide resolved
jordanjanakievski
jordanjanakievski approved these changes Nov 5, 2023
View reviewed changes
Copy link
Collaborator

@jordanjanakievski jordanjanakievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is looking great, super organized, and easy to follow!

DanielDervishi
DanielDervishi approved these changes Nov 5, 2023
View reviewed changes
Copy link
Collaborator

@DanielDervishi DanielDervishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Emily!

@3milyfz 3milyfz merged commit a014f1f into main Nov 5, 2023
2 checks passed
@3milyfz 3milyfz deleted the emilyz/tces-10-urd-login-page branch November 5, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielDervishi DanielDervishi DanielDervishi approved these changes

@jordanjanakievski jordanjanakievski jordanjanakievski approved these changes

Assignees

@3milyfz 3milyfz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3milyfz @jordanjanakievski @DanielDervishi