Feature/update coverage (#19)

* fix: Fix adding Kotlin sourceset change: Add less strict coverage exclusions * change: disable ktlint reports by default * docs: update changelog * docs: Update Readme
usefulness · Jan 23, 2020 · 1531835 · 1531835
1 parent 5f3fceb
commit 1531835
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 5 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.5.0] - 2020-01-23
+
+### Changed
+- Disable _ktlint_ reports by default
+- Add less strict coverage exclusions
+
+## Fixed
+- Fix setting `/src/*/kotlin/` source sets.
 
 ## [0.4.0] - 2020-01-12
 
@@ -42,7 +50,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 - Add Quality Plugin - `com.starter.quality`
 
-[Unreleased]: https://github.com/mateuszkwiecinski/project-starter/compare/release/0.4.0...HEAD
+[Unreleased]: https://github.com/mateuszkwiecinski/project-starter/compare/release/0.5.0...HEAD
+[0.5.0]: https://github.com/mateuszkwiecinski/project-starter/compare/release/0.4.0.../release/0.5.0
 [0.4.0]: https://github.com/mateuszkwiecinski/project-starter/compare/release/0.3.0.../release/0.4.0
 [0.3.0]: https://github.com/mateuszkwiecinski/project-starter/compare/release/0.2.0.../release/0.3.0
 [0.2.0]: https://github.com/mateuszkwiecinski/project-starter/compare/release/0.1.0.../release/0.2.0

diff --git a/Readme.md b/Readme.md
@@ -160,7 +160,6 @@ commonConfig {
     - `formatOnCompile` - defines if ktlint should format source code on every compilation
 - `versioningPlugin`:
     - `enabled` - enables/disables [Versioning Plugin](#versioning-plugin)
-    - `enabled` - defines if ktlint should format source code on every compilation
 
 ### Day-to-day use
 After applying library/application plugin there are appropriate tasks added:

diff --git a/plugins/src/main/kotlin/com/project/starter/modules/internal/AndroidPluginUtils.kt b/plugins/src/main/kotlin/com/project/starter/modules/internal/AndroidPluginUtils.kt
@@ -68,7 +68,7 @@ internal inline fun <reified T> Project.withExtension(crossinline action: Projec
     }
 
 private fun BaseExtension.addKotlinSourceSets() {
-    sourceSets.whenObjectAdded { set ->
+    sourceSets.all { set ->
         val withKotlin = set.java.srcDirs.map { it.path.replace("java", "kotlin") }
         set.java.setSrcDirs(set.java.srcDirs + withKotlin)
     }

diff --git a/plugins/src/main/kotlin/com/project/starter/quality/internal/AndroidCoverage.kt b/plugins/src/main/kotlin/com/project/starter/quality/internal/AndroidCoverage.kt
@@ -63,7 +63,8 @@ private val dagger = listOf(
     "**/*_MembersInjector.class",
     "**/Dagger*Component.class",
     "**/Dagger*Component${"$"}Builder.class",
-    "**/*Module_*Factory.class"
+    "**/*_*Factory.class",
+    "**/*_Factory.class"
 )
 
 private val excludes = databinding + framework + butterKnife + dagger
diff --git a/plugins/src/main/kotlin/com/project/starter/quality/internal/Ktlint.kt b/plugins/src/main/kotlin/com/project/starter/quality/internal/Ktlint.kt
@@ -13,7 +13,7 @@ internal fun Project.configureKtlint() {
         it.indentSize = 4
         it.continuationIndentSize = 4
         it.experimentalRules = true
-        it.reporters = arrayOf("checkstyle", "plain")
+        it.reporters = emptyArray()
         it.disabledRules = arrayOf("import-ordering")
     }