Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #15 by pointing to /mode/... instead of /reference/... To poin… #66

Closed
wants to merge 1 commit into from

Conversation

JustKuzya
Copy link
Contributor

Committer Notes

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

This fix should point to the local OSCAL-Reference types (nist-pages or local-local), not global metaschema, for metaschema. To point HREF to a new root, a new XSL variable would need to be added. I'd like to suggest also refactoring for the "href" composition template and relocate it to the unified callable place to have one file entry, instead of 7

… To point to original Metaschema types much bigger refactoring would be needed!
@JustKuzya JustKuzya requested a review from a team as a code owner August 25, 2023 18:33
Copy link
Collaborator

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @JustKuzya let me know as your thoughts develop re: parameterization. Is there a common module where it would make sense to define a variable?

Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the comment in this PR description is specifically is the opposite of what was requested (usnistgov/OSCAL-Reference#15).

As reported by @JustKuzya in usnistgov/OSCAL-Reference#6 (comment), the reference pages still link to internalized OSCAL data types incorrectly after the website migration.

An example link (now incorrect) to a copy of the data types on the OSCAL site is below.

https://pages.nist.gov/OSCAL-Reference/reference/datatypes/#uri-reference

An updated correct example (and all those like it) will point to the correct upstream link, such as the one below.

https://pages.nist.gov/metaschema/specification/datatypes/#uri-reference

This PR should point to Metaschema types.

OSCAL does not have its own native data types, the types are Metaschema types (or Metaschema's translation to JSON and XML schema types respectively, but still not specific to OSCAL). The duplication and confusion in this PR is what we are hoping to avoid in the future for our team and community.

Please point to the Metaschema types as requested, thank you.

@nikitawootten-nist
Copy link
Collaborator

Superseded by #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants