Add sound effects using the built-in buzzer #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Abhiram Patil <[email protected]> Co-authored-by: Vincent Le <[email protected]> Co-authored-by: mylesmorrison <[email protected]> Co-authored-by: Vj-Betala <[email protected]>
calebchalmers
added
the
needs-testing
Closed
calebchalmers
removed
the
needs-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can play these sounds during startup, after certain commands like beyblading, or even in response to game state updates (e.g. after healing).
This is of course assuming that playing sounds during a match doesn't break any RMNA rules 🤷