-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make jre folder platform dependent #632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to test in exports to be sure we don't break them.
I tested linux editor and export templates. Could you test windows and mac? (I don't think testing on mobile is necessary but you can if you want to :-) ) |
96984d5
to
d51d4b9
Compare
Tested it on mac and windows as well in the meantime. Just graalvm is missing testing on those platforms |
d51d4b9
to
349f888
Compare
349f888
to
bba1849
Compare
I don't remember: did we test it on all platforms ? |
I did on all platforms except mobile and graalvm for windows and macos |
After my last change i did test the exports on macos (as thats where I'm working on today) |
I will test it on graalVM native-image for iOS. |
Tested on iOS |
This makes the jre folder platform dependent.
This makes it possible for a project to have multiple jre folder simultaneously on the file system. The module then automatically picks the correct one for the current platform.
The main advantage of this is that on a project with multiple people working on it, the embedded jre can be committed to the repository for each platform together with the built jar and a project member does not need to have java locally installed and JAVA_HOME set. Which is especially useful if one is working with non programmers.
Note: Breaking change. Needs special notes in release notes!