Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
godot-library
module has a dependency ontools-common
(string operations and some constant).I move those dependencies to a new
common
module now used bygodot-library
andtools-common
.I also decided to move the utils package from
godot-library
to this new module. This serves as a first step toward making the API split easier.So far the plan is to have a 4 module chain
Common
=>Internal
=>Core
=>API
, it means that I need a bunch of utilities in that common module. To that end, I also created a new "interop" package with basic logic to handle C++ pointers.The number of line changes is scary but it's 99% just renames and package updates.
The only new stuff is the module itself + its "interop" package.