Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new common module #726

Merged
merged 8 commits into from
Oct 14, 2024
Merged

Add new common module #726

merged 8 commits into from
Oct 14, 2024

Conversation

CedNaru
Copy link
Member

@CedNaru CedNaru commented Oct 13, 2024

Currently, the godot-library module has a dependency on tools-common (string operations and some constant).
I move those dependencies to a new common module now used by godot-library and tools-common.

I also decided to move the utils package from godot-library to this new module. This serves as a first step toward making the API split easier.
So far the plan is to have a 4 module chain Common => Internal => Core => API, it means that I need a bunch of utilities in that common module. To that end, I also created a new "interop" package with basic logic to handle C++ pointers.

The number of line changes is scary but it's 99% just renames and package updates.
The only new stuff is the module itself + its "interop" package.

@CedNaru CedNaru requested review from chippmann and piiertho October 13, 2024 09:59
kt/common/build.gradle.kts Outdated Show resolved Hide resolved
kt/godot-library/build.gradle.kts Show resolved Hide resolved
@CedNaru CedNaru requested a review from chippmann October 14, 2024 09:49
@CedNaru CedNaru merged commit 4151313 into master Oct 14, 2024
57 checks passed
@CedNaru CedNaru deleted the improvement/common-module branch October 14, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants