Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor common selects #603

Merged
merged 14 commits into from
Nov 14, 2023
Merged

Conversation

jfdoming
Copy link
Contributor

Notion ticket link

Work as part of Add start / end time in test session

Implementation description

Medium-size refactor to selects within the app to use a common component. Rationale:

  1. UI standardization: we currently have several different variants of Select components used throughout the app. This PR merges them all to one definition.
  2. Code reuse: this moves a bunch of logic into a standard component, and simplifies access patterns (no more manual typing necessary). This is in preparation for the time picker, which uses selects.

Steps to test

  1. View the selects I updated (mainly: teacher creation, student sign-in, table filtering, multi-option assessment creation) and make sure they look good.

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@jfdoming jfdoming temporarily deployed to staging October 22, 2023 19:04 — with GitHub Actions Inactive
@jfdoming jfdoming force-pushed the julian/refactor-common-selects branch from 224dbe1 to 73bd44b Compare October 22, 2023 19:04
@jfdoming jfdoming temporarily deployed to staging October 22, 2023 19:04 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 22, 2023

Visit the preview URL for this PR (updated for commit 8308a7e):

https://jump-math-staging--pr603-julian-refactor-comm-jucdvw4b.web.app

(expires Thu, 09 Nov 2023 04:15:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c42d8d0d853b05885664a2dd73f8245f4333ae51

Copy link
Collaborator

@carissa-tang carissa-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love the refactor!

@carissa-tang
Copy link
Collaborator

another case to check:

  1. create test and save
  2. fails bc grade level is [grade_value] instead of grade_value

@jfdoming jfdoming temporarily deployed to staging October 29, 2023 21:06 — with GitHub Actions Inactive
@jfdoming jfdoming requested a review from carissa-tang October 29, 2023 21:06
@carissa-tang
Copy link
Collaborator

carissa-tang commented Oct 30, 2023

i remember we had this issue with the short answer input. now i see it with MC and multiselect. is this an easy fix?

Screen.Recording.2023-10-29.at.11.31.22.PM.mov

@carissa-tang
Copy link
Collaborator

carissa-tang commented Oct 30, 2023

do you mind updating these two modals as well to replace the generic top message and remove the bottom one? for consistency

image image

@jfdoming
Copy link
Contributor Author

jfdoming commented Nov 2, 2023

@carissa-tang ready for review!

Copy link
Collaborator

@carissa-tang carissa-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !!

@jfdoming jfdoming merged commit c39505c into staging Nov 14, 2023
7 checks passed
@jfdoming jfdoming deleted the julian/refactor-common-selects branch November 14, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants