-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor common selects #603
Conversation
224dbe1
to
73bd44b
Compare
Visit the preview URL for this PR (updated for commit 8308a7e): https://jump-math-staging--pr603-julian-refactor-comm-jucdvw4b.web.app (expires Thu, 09 Nov 2023 04:15:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c42d8d0d853b05885664a2dd73f8245f4333ae51 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love the refactor!
frontend/src/components/admin/assessment-creation/BasicInformation.tsx
Outdated
Show resolved
Hide resolved
...mponents/admin/question-creation/question-elements/modals/multi-option/SelectOptionCount.tsx
Show resolved
Hide resolved
another case to check:
|
i remember we had this issue with the short answer input. now i see it with MC and multiselect. is this an easy fix? Screen.Recording.2023-10-29.at.11.31.22.PM.mov |
@carissa-tang ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice !!
Notion ticket link
Work as part of Add start / end time in test session
Implementation description
Medium-size refactor to selects within the app to use a common component. Rationale:
Select
components used throughout the app. This PR merges them all to one definition.Steps to test
What should reviewers focus on?
Checklist