feat: preview assessment from teacher dashboard #605
Conversation
|
Visit the preview URL for this PR (updated for commit fef2852): https://jump-math-staging--pr605-joyce-teacher-previe-khzdlc7a.web.app (expires Tue, 31 Oct 2023 18:38:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c42d8d0d853b05885664a2dd73f8245f4333ae51 |
| }>(GET_TEST); | ||
|
|
||
| const previewAssessment = async (assessmentId: string) => { | ||
| const { data } = await previewAssessmentQuery({ |
There was a problem hiding this comment.
nit: instead of checking for nullish data, we should catch exceptions here, since awaited Apollo lazy queries throw any error instead of returning it
| }>(GET_TEST); | ||
|
|
||
| const onPreviewTest = async () => { | ||
| const { data } = await previewTest({ |
| <PopoverButton name="Delete" onClick={openDeleteModal} /> | ||
| <> | ||
| <PopoverButton name="Delete" onClick={openDeleteModal} /> | ||
| <Divider /> |
There was a problem hiding this comment.
Do we need the extra divider here? I think VStack with the divider prop should automatically handle it, provided you remove the extra fragment (<>). (If we want to hide the whole popover for past sessions, it would make more sense IMO to either conditionally return null from this component, or (better) conditionally render the entire TestSessionListItemPopover component in the parent TestSessionListItem or wherever else this component is used.)
Notion ticket link
Preview Assessment screen in Teacher Dashboard
Implementation description
TestSessionListItem